[Gnash-commit] gnash ./ChangeLog server/Date.cpp server/Date.h...

[Michael Carlson]

CVSROOT:        /sources/gnash
Module name:    gnash
Branch:         
Changes by:     Michael Carlson <address@hidden>        06/03/08 16:50:17

Modified files:
        .              : ChangeLog 
        server         : Date.cpp Date.h array.cpp 

Log message:
        Implement all the basic "set" functions in Date, rename Date::set() to 
Date::setDate() in accordance with two unofficial references online, Add some 
sorting-related constants to array

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/gnash/ChangeLog.diff?tr1=1.178&tr2=1.179&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/gnash/gnash/server/Date.cpp.diff?tr1=1.6&tr2=1.7&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/gnash/gnash/server/Date.h.diff?tr1=1.4&tr2=1.5&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/gnash/gnash/server/array.cpp.diff?tr1=1.12&tr2=1.13&r1=text&r2=text

Patches:
Index: gnash/ChangeLog
diff -u gnash/ChangeLog:1.178 gnash/ChangeLog:1.179
--- gnash/ChangeLog:1.178       Wed Mar  8 14:57:49 2006
+++ gnash/ChangeLog     Wed Mar  8 16:50:17 2006
@@ -3,9 +3,12 @@
        * backend/gnash.cpp: Fix typo in and add newline to error message
        Avoid infinite loop and make gnash still poll for SDL events when
        libxml is not present
-       * server/Date.cpp: Implement Date::gettimezoneoffset, cleanup
-       messages to user a bit
-       * server/Date.h: Add minutesEast variable to store timezone
+       * server/Date.cpp: Implement Date::gettimezoneoffset, all the 
+       basic "set" functions, cleanup messages to user a bit, rename
+       set() to setDate(), in accordance with two unofficial references
+       * server/Date.h: Add minutesEast variable to store timezone,
+       rename set() to setDate()
+       * server/array.cpp: Add some constants related to sorting
 
 2006-03-06  Rob Savoye  <address@hidden>
 
Index: gnash/server/Date.cpp
diff -u gnash/server/Date.cpp:1.6 gnash/server/Date.cpp:1.7
--- gnash/server/Date.cpp:1.6   Wed Mar  8 14:57:49 2006
+++ gnash/server/Date.cpp       Wed Mar  8 16:50:17 2006
@@ -101,7 +101,7 @@
 }
 
 void
-Date::set()
+Date::setDate()
 {
     log_msg("%s:unimplemented \n", __FUNCTION__);
 }
@@ -231,7 +231,7 @@
     date_obj->set_member("getutcmonth", &date_getutcmonth);
     date_obj->set_member("getutcseconds", &date_getutcseconds);
     date_obj->set_member("getyear", &date_getyear);
-    date_obj->set_member("set", &date_set);
+    date_obj->set_member("setdate", &date_setdate);
     date_obj->set_member("setfullyear", &date_setfullyear);
     date_obj->set_member("sethours", &date_sethours);
     date_obj->set_member("setmilliseconds", &date_setmilliseconds);
@@ -349,26 +349,43 @@
     date_as_object* date = (date_as_object*) (as_object*) fn.this_ptr;
     fn.result->set_int(date->obj.year);
 }
-void date_set(const fn_call& fn) {
-    log_msg("%s:unimplemented \n", __FUNCTION__);
+// TODO: for all these "set" functions, what do we do if sent illegal values?
+// Clamp them to a proper range? Ignore and keep previous value? Throw an 
error?
+// Right now we're doing _none_ of these, because I don't know what's 
appropriate!
+void date_setdate(const fn_call& fn) {
+    assert(fn.nargs == 1);
+    date_as_object* date = (date_as_object*) (as_object*) fn.this_ptr;
+    date->obj.date = (long int)(fn.arg(0).to_number());
 }
 void date_setfullyear(const fn_call& fn) {
-    log_msg("%s:unimplemented \n", __FUNCTION__);
+    assert(fn.nargs == 1);
+    date_as_object* date = (date_as_object*) (as_object*) fn.this_ptr;
+    date->obj.year = (long int)(fn.arg(0).to_number() - 1900);
 }
 void date_sethours(const fn_call& fn) {
-    log_msg("%s:unimplemented \n", __FUNCTION__);
+    assert(fn.nargs == 1);
+    date_as_object* date = (date_as_object*) (as_object*) fn.this_ptr;
+    date->obj.hour = (long int)(fn.arg(0).to_number());
 }
 void date_setmilliseconds(const fn_call& fn) {
-    log_msg("%s:unimplemented \n", __FUNCTION__);
+    assert(fn.nargs == 1);
+    date_as_object* date = (date_as_object*) (as_object*) fn.this_ptr;
+    date->obj.millisecond = (long int)(fn.arg(0).to_number());
 }
 void date_setminutes(const fn_call& fn) {
-    log_msg("%s:unimplemented \n", __FUNCTION__);
+    assert(fn.nargs == 1);
+    date_as_object* date = (date_as_object*) (as_object*) fn.this_ptr;
+    date->obj.minute = (long int)(fn.arg(0).to_number());
 }
 void date_setmonth(const fn_call& fn) {
-    log_msg("%s:unimplemented \n", __FUNCTION__);
+    assert(fn.nargs == 1);
+    date_as_object* date = (date_as_object*) (as_object*) fn.this_ptr;
+    date->obj.month = (long int)(fn.arg(0).to_number());
 }
 void date_setseconds(const fn_call& fn) {
-    log_msg("%s:unimplemented \n", __FUNCTION__);
+    assert(fn.nargs == 1);
+    date_as_object* date = (date_as_object*) (as_object*) fn.this_ptr;
+    date->obj.second = (long int)(fn.arg(0).to_number());
 }
 void date_settime(const fn_call& fn) {
     log_msg("%s:unimplemented \n", __FUNCTION__);
@@ -395,7 +412,9 @@
     log_msg("%s:unimplemented \n", __FUNCTION__);
 }
 void date_setyear(const fn_call& fn) {
-    log_msg("%s:unimplemented \n", __FUNCTION__);
+    assert(fn.nargs == 1);
+    date_as_object* date = (date_as_object*) (as_object*) fn.this_ptr;
+    date->obj.year = (long int)(fn.arg(0).to_number());
 }
 void date_tostring(const fn_call& fn) {
     log_msg("%s:unimplemented \n", __FUNCTION__);
Index: gnash/server/Date.h
diff -u gnash/server/Date.h:1.4 gnash/server/Date.h:1.5
--- gnash/server/Date.h:1.4     Wed Mar  8 14:57:49 2006
+++ gnash/server/Date.h Wed Mar  8 16:50:17 2006
@@ -43,7 +43,7 @@
    void getUTCMonth();
    void getUTCSeconds();
    void getYear();
-   void set();
+   void setDate();
    void setFullYear();
    void setHours();
    void setMilliseconds();
@@ -93,7 +93,7 @@
 void date_getutcmonth(const fn_call& fn);
 void date_getutcseconds(const fn_call& fn);
 void date_getyear(const fn_call& fn);
-void date_set(const fn_call& fn);
+void date_setdate(const fn_call& fn);
 void date_setfullyear(const fn_call& fn);
 void date_sethours(const fn_call& fn);
 void date_setmilliseconds(const fn_call& fn);
Index: gnash/server/array.cpp
diff -u gnash/server/array.cpp:1.12 gnash/server/array.cpp:1.13
--- gnash/server/array.cpp:1.12 Wed Mar  1 00:54:43 2006
+++ gnash/server/array.cpp      Wed Mar  8 16:50:17 2006
@@ -353,6 +353,11 @@
                array->set_member("sortOn", &array_not_impl);
                array->set_member("reverse", &array_reverse);
                array->set_member("toString", &array_to_string);
+               array->set_member("CASEINSENSITIVE", 1);
+               array->set_member("DESCENDING", 2);
+               array->set_member("UNIQUESORT", 4);
+               array->set_member("RETURNINDEXEDARRAY", 8);
+               array->set_member("NUMERIC", 16);
        }
 
        void    as_global_array_ctor(const fn_call& fn)