Re: [Gnash-commit] gnash/backend render_handler_ogl.cpp

[strk]

On Mon, Aug 21, 2006 at 01:28:34PM +0000, Vitaly Alexeev wrote:
> CVSROOT:      /sources/gnash
> Module name:  gnash
> Changes by:   Vitaly Alexeev <alexeev>        06/08/21 13:28:33
> 
> Modified files:
>       backend        : render_handler_ogl.cpp 
> 
> Log message:
>       attempting to do multithread opengl
> 
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/gnash/backend/render_handler_ogl.cpp?cvsroot=gnash&r1=1.14&r2=1.15
> 
> Patches:
> Index: render_handler_ogl.cpp
> ===================================================================
> RCS file: /sources/gnash/gnash/backend/render_handler_ogl.cpp,v
> retrieving revision 1.14
> retrieving revision 1.15
> diff -u -b -r1.14 -r1.15
> --- render_handler_ogl.cpp    27 Jul 2006 14:54:43 -0000      1.14
> +++ render_handler_ogl.cpp    21 Aug 2006 13:28:33 -0000      1.15
> @@ -14,6 +14,10 @@
>  
>  #include <cstring>
>  
> +#if defined(_WIN32) || defined(WIN32)
> +#    include <Windows.h>
> +#endif
> +
>  using namespace gnash;
>  
>  // choose the resampling method:
> @@ -45,6 +49,8 @@
>           glDeleteTextures(1, (GLuint*) &m_texture_id);
>       }
>      }
> +
> +     virtual void layout_image(image::image_base* im);
>  };
>  
>  struct render_handler_ogl : public gnash::render_handler
> @@ -117,7 +123,7 @@
>       };
>       mode    m_mode;
>       gnash::rgba     m_color;
> -     const gnash::bitmap_info*       m_bitmap_info;
> +     gnash::bitmap_info*     m_bitmap_info;

This modification introduced some warnings about const/non-const casts.
Please remember to build with warnings turned on.

If semantic of some classes change it's worth adding a deeper description
about why and how.

Current topic on renderers should be that of task # 5837
https://savannah.gnu.org/task/?func=detailitem&item_id=5837

--strk;