Re: [Gnash-commit] gnash ChangeLog server/parser/movie_def_impl.cpp

[Sandro Santilli]

On Mon, Aug 28, 2006 at 01:20:56PM +0200, Markus Gothe wrote:
> Are you sure we want to have a prefixed decrease on 'i'?
> 
> This implicates that "const import_info&      inf = m_imports[i-1];" will
> never apply to the last element in m_imports.
> 
> In my eyes:
> " for (size_t i = m_imports.size(); i > 0; i--)
>         {
>          const import_info&   inf = m_imports[i-1];"
> 
> look more correct or:

Is this any different from --i ?

> " for (size_t i = m_imports.size(); i >= 0; i--)
>         {
>          const import_info&   inf = m_imports[i];"

i >= 0 will always be true, being i an unsigned type.

A cleaner solution would be using m_imports.rbegin() and rend()

--strk;