[Gnash-commit] gnash ChangeLog gui/gui.cpp gui/gui.h

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  06/10/17 13:12:43

Modified files:
        .              : ChangeLog 
        gui            : gui.cpp gui.h 

Log message:
                * gui/gui.{cpp,h}: notify_mouse_moved made non-static; call
                  display() after mouse move notification to immediately
                  show changed triggered by any event handler. This is an
                  overkill and needs better architecture, but at least it is
                  correct now.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.1262&r2=1.1263
http://cvs.savannah.gnu.org/viewcvs/gnash/gui/gui.cpp?cvsroot=gnash&r1=1.30&r2=1.31
http://cvs.savannah.gnu.org/viewcvs/gnash/gui/gui.h?cvsroot=gnash&r1=1.24&r2=1.25

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.1262
retrieving revision 1.1263
diff -u -b -r1.1262 -r1.1263
--- ChangeLog   17 Oct 2006 12:42:28 -0000      1.1262
+++ ChangeLog   17 Oct 2006 13:12:43 -0000      1.1263
@@ -1,5 +1,10 @@
 2006-10-17 Sandro Santilli <address@hidden>
 
+       * gui/gui.{cpp,h}: notify_mouse_moved made non-static; call
+         display() after mouse move notification to immediately
+         show changed triggered by any event handler. This is an
+         overkill and needs better architecture, but at least it is
+         correct now.
        * gui/gui.{cpp,h}: extracted a display() function out of
          advance_movie(), for possible reuse from event notifiers.
        * server/edit_text_character.cpp: commented out debugging line

Index: gui/gui.cpp
===================================================================
RCS file: /sources/gnash/gnash/gui/gui.cpp,v
retrieving revision 1.30
retrieving revision 1.31
diff -u -b -r1.30 -r1.31
--- gui/gui.cpp 17 Oct 2006 12:42:28 -0000      1.30
+++ gui/gui.cpp 17 Oct 2006 13:12:43 -0000      1.31
@@ -210,6 +210,13 @@
 {
        movie_interface* m = get_current_root();
        m->notify_mouse_moved(x, y);
+
+       // it might be worth having notify_mouse_moved
+       // return a variable telling wheter any event was
+       // triggered. If no event was triggered we can
+       // directly skip the display call.
+       //
+       display(m);
 }
 
 void
@@ -303,8 +310,8 @@
 {
        assert(gui);
 
-  
 //    GNASH_REPORT_FUNCTION;
+
        gnash::movie_interface* m = gnash::get_current_root();
 
   // Advance movie by one frame

Index: gui/gui.h
===================================================================
RCS file: /sources/gnash/gnash/gui/gui.h,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -b -r1.24 -r1.25
--- gui/gui.h   17 Oct 2006 12:42:28 -0000      1.24
+++ gui/gui.h   17 Oct 2006 13:12:43 -0000      1.25
@@ -174,7 +174,7 @@
     //
     /// @param x The mouse coordinate X component in pixels.
     /// @param y The mouse coordinate Y component in pixels.
-    static void notify_mouse_moved(int x, int y);
+    void notify_mouse_moved(int x, int y);
 
     /// Mouse notification callback to be called when the mouse is clicked.
     //