[Gnash-commit] gnash ChangeLog server/swf/ASHandlers.cpp

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  06/10/17 16:13:45

Modified files:
        .              : ChangeLog 
        server/swf     : ASHandlers.cpp 

Log message:
                * server/swf/ASHandlers.cpp (ActionGetVariable): optimizations:
                  avoid pop/push; avoid unneeded as_value copies.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.1267&r2=1.1268
http://cvs.savannah.gnu.org/viewcvs/gnash/server/swf/ASHandlers.cpp?cvsroot=gnash&r1=1.74&r2=1.75

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.1267
retrieving revision 1.1268
diff -u -b -r1.1267 -r1.1268
--- ChangeLog   17 Oct 2006 15:32:47 -0000      1.1267
+++ ChangeLog   17 Oct 2006 16:13:45 -0000      1.1268
@@ -1,5 +1,7 @@
 2006-10-17 Sandro Santilli <address@hidden>
 
+       * server/swf/ASHandlers.cpp (ActionGetVariable): optimizations:
+         avoid pop/push; avoid unneeded as_value copies.
        * server: Makefile.am, rect.cpp rect.h: put rect class in it's own
          files, fixed width() and height() to return 0 when rect is
          null.

Index: server/swf/ASHandlers.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/swf/ASHandlers.cpp,v
retrieving revision 1.74
retrieving revision 1.75
diff -u -b -r1.74 -r1.75
--- server/swf/ASHandlers.cpp   5 Oct 2006 14:35:03 -0000       1.74
+++ server/swf/ASHandlers.cpp   17 Oct 2006 16:13:45 -0000      1.75
@@ -34,7 +34,7 @@
 // forward this exception.
 //
 
-/* $Id: ASHandlers.cpp,v 1.74 2006/10/05 14:35:03 strk Exp $ */
+/* $Id: ASHandlers.cpp,v 1.75 2006/10/17 16:13:45 strk Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -961,23 +961,23 @@
        as_environment& env = thread.env;
        ensure_stack(env, 1); // variable name
 
-       as_value var_name = env.pop();
-       tu_string var_string = var_name.to_tu_string();
+       as_value& top_value = env.top(0);
+       tu_string var_string = top_value.to_tu_string();
 
-       as_value variable = env.get_variable(var_string);
-       env.push(variable);
+       top_value = env.get_variable(var_string);
+       //env.top(0) = variable;
 
        IF_VERBOSE_ACTION
        (
-               if (variable.to_object() == NULL) {
+               if (top_value.to_object() == NULL) {
                        log_action("-- get var: %s=%s",
                                var_string.c_str(),
-                               variable.to_tu_string().c_str());
+                               top_value.to_tu_string().c_str());
                } else {
                        log_action("-- get var: %s=%s at %p",
                                var_string.c_str(),
-                               variable.to_tu_string().c_str(),
-                               (void*)variable.to_object());
+                               top_value.to_tu_string().c_str(),
+                               (void*)top_value.to_object());
                }
        );
 }