Re: [Gnash-commit] gnash/server/asobj LocalConnection.cpp LocalCon...

[Rob Savoye]

Vitaly Alexeev wrote:

> ===================================================================
> RCS file: /sources/gnash/gnash/server/asobj/LocalConnection.cpp,v
> retrieving revision 1.3
> retrieving revision 1.4
> diff -u -b -r1.3 -r1.4
> --- LocalConnection.cpp       22 Oct 2006 01:00:54 -0000      1.3
> +++ LocalConnection.cpp       27 Oct 2006 14:29:49 -0000      1.4
> @@ -63,7 +63,9 @@
>  void
>  LocalConnection::close()
>  {
> +#ifndef NETWORK_CONN
>      closeMem();
> +#endif

  LocalConnection uses shared memory, not a network connection. Network
connections are done with NetConnection. So at the least we probably
want to rename the ifdef...

  We also would prefer to use Boost threads, not SDL_Threads. We now
have stable Boost support, and I believe the config code to find the
Boost thread library is now stable.

  Just to mention it, it's great you got this working. I'm relatively
excited to see this functionality get added so people stop griping that
Gnash doesn't work with YouTube.

        - rob -