[Gnash-commit] gnash ChangeLog gui/gui.cpp

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  06/12/06 14:39:01

Modified files:
        .              : ChangeLog 
        gui            : gui.cpp 

Log message:
                * gui/gui.cpp (display): when debugging invalidated bounds
                  show only the last invalidated region. this slows the
                  rendering, but when debugging you probably don't care.
                  BTW, this commit also makes NO debugging the default.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.1869&r2=1.1870
http://cvs.savannah.gnu.org/viewcvs/gnash/gui/gui.cpp?cvsroot=gnash&r1=1.53&r2=1.54

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.1869
retrieving revision 1.1870
diff -u -b -r1.1869 -r1.1870
--- ChangeLog   6 Dec 2006 12:48:50 -0000       1.1869
+++ ChangeLog   6 Dec 2006 14:39:01 -0000       1.1870
@@ -1,5 +1,12 @@
 2006-12-06 Sandro Santilli <address@hidden>
 
+       * gui/gui.cpp (display): when debugging invalidated bounds
+         show only the last invalidated region. this slows the
+         rendering, but when debugging you probably don't care.
+         BTW, this commit also makes NO debugging the default.
+
+2006-12-06 Sandro Santilli <address@hidden>
+
        * server/sprite_instance.cpp (get_invalidated_bounds):
          cleaned up debugging output to use rect::toString.
        * server/movie_root.cpp (get_invalidated_bounds): remove

Index: gui/gui.cpp
===================================================================
RCS file: /sources/gnash/gnash/gui/gui.cpp,v
retrieving revision 1.53
retrieving revision 1.54
diff -u -b -r1.53 -r1.54
--- gui/gui.cpp 6 Dec 2006 10:21:32 -0000       1.53
+++ gui/gui.cpp 6 Dec 2006 14:39:01 -0000       1.54
@@ -35,7 +35,7 @@
 /// In the future, enabling this might actually use a runtime flag
 /// as an additional conditional.
 ///
-#define ENABLE_REGION_UPDATES_DEBUGGING 1
+//#define ENABLE_REGION_UPDATES_DEBUGGING 1
 
 #ifdef ENABLE_REGION_UPDATES_DEBUGGING
 // a runtime check would make the { x; } block conditionally executed
@@ -272,16 +272,26 @@
 
        if ( ! changed_bounds.is_null() ) // use 'else'?
        {
-               // Tell the GUI(!) that we only need to update this region. 
Note the GUI can
-               // do whatever it wants with this information. It may simply 
ignore the 
-               // bounds (which will normally lead into a complete redraw), or 
it may
-               // extend or shrink the bounds as it likes. So, by calling 
-               // set_invalidated_bounds we have no guarantee that only this 
part of the
-               // stage is rendered again.
+               // Tell the GUI(!) that we only need to update this
+               // region. Note the GUI can do whatever it wants with
+               // this information. It may simply ignore the bounds
+               // (which will normally lead into a complete redraw),
+               // or it may extend or shrink the bounds as it likes. So,
+               // by calling set_invalidated_bounds we have no guarantee
+               // that only this part of the stage is rendered again.
+#ifdef ENABLE_REGION_UPDATES_DEBUGGING
+               // redraw the full screen so that only the
+               // *new* invalidated region is visible
+               // (helps debugging)
+               rect worldregion; worldregion.set_world();
+               set_invalidated_region(worldregion);
+#else
                set_invalidated_region(changed_bounds);
+#endif
 
-               // render the frame. It's up to the GUI/renderer combination to 
do any
-               // clipping, if desired.     
+               // render the frame.
+               // It's up to the GUI/renderer combination
+               // to do any clipping, if desired.     
                m->display();
   
                // show invalidated region using a red rectangle