[Gnash-commit] gnash server/as_environment.cpp ChangeLog

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  06/12/20 14:33:39

Modified files:
        server         : as_environment.cpp 
        .              : ChangeLog 

Log message:
                * server/as_environment.cpp (find_target(const as_value&)):
                  Use as_value::is_object() rather then comparing get_type().
                  This helps when as_value will support MOVIECLIP types.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_environment.cpp?cvsroot=gnash&r1=1.46&r2=1.47
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.1977&r2=1.1978

Patches:
Index: server/as_environment.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/as_environment.cpp,v
retrieving revision 1.46
retrieving revision 1.47
diff -u -b -r1.46 -r1.47
--- server/as_environment.cpp   19 Dec 2006 19:05:58 -0000      1.46
+++ server/as_environment.cpp   20 Dec 2006 14:33:39 -0000      1.47
@@ -16,7 +16,7 @@
 
 //
 
-/* $Id: as_environment.cpp,v 1.46 2006/12/19 19:05:58 strk Exp $ */
+/* $Id: as_environment.cpp,v 1.47 2006/12/20 14:33:39 strk Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -416,7 +416,13 @@
 character*
 as_environment::find_target(const as_value& val) const
 {
-       if (val.get_type() == as_value::OBJECT)
+       // TODO: should we reduce this whole function to
+       //       find_target(val.to_std_string()) ?
+       //       a quick test shows it would work, I'm just not sure about
+       //       edit_text_chars, that might return the text value rather
+       //       then their target ...
+
+       if ( val.is_object() )
        {
                as_object* obj = val.to_object();
                assert (obj);

Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.1977
retrieving revision 1.1978
diff -u -b -r1.1977 -r1.1978
--- ChangeLog   20 Dec 2006 10:06:50 -0000      1.1977
+++ ChangeLog   20 Dec 2006 14:33:39 -0000      1.1978
@@ -1,5 +1,8 @@
 2006-12-20 Sandro Santilli <address@hidden>
 
+       * server/as_environment.cpp (find_target(const as_value&)):
+         Use as_value::is_object() rather then comparing get_type().
+         This helps when as_value will support MOVIECLIP types.
        * server/sprite_instance.cpp (get_member): fixed 
          CHECK_FOR_NAME_CLASHES block.
        * testsuite/movies.all/README: filled 'origin' field