[Gnash-commit] gnash ChangeLog server/as_value.h

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  06/12/21 08:55:25

Modified files:
        .              : ChangeLog 
        server         : as_value.h 

Log message:
                * server/as_value.h: m_type, m_string_value and values union
                  made private.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.1984&r2=1.1985
http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_value.h?cvsroot=gnash&r1=1.20&r2=1.21

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.1984
retrieving revision 1.1985
diff -u -b -r1.1984 -r1.1985
--- ChangeLog   21 Dec 2006 08:13:27 -0000      1.1984
+++ ChangeLog   21 Dec 2006 08:55:24 -0000      1.1985
@@ -1,5 +1,7 @@
 2006-12-21 Sandro Santilli <address@hidden>
 
+       * server/as_value.h: m_type, m_string_value and values union
+         made private.
        * testsuite/misc-ming.all/VarAndCharClashTest.as:
          added new tests checking integrity of a *reference*
          to the movieclip.

Index: server/as_value.h
===================================================================
RCS file: /sources/gnash/gnash/server/as_value.h,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -b -r1.20 -r1.21
--- server/as_value.h   20 Dec 2006 15:56:02 -0000      1.20
+++ server/as_value.h   21 Dec 2006 08:55:25 -0000      1.21
@@ -17,7 +17,7 @@
 // 
 //
 
-/* $Id: as_value.h,v 1.20 2006/12/20 15:56:02 strk Exp $ */
+/* $Id: as_value.h,v 1.21 2006/12/21 08:55:25 strk Exp $ */
 
 #ifndef GNASH_AS_VALUE_H
 #define GNASH_AS_VALUE_H
@@ -104,23 +104,6 @@
                MOVIECLIP
        };
 
-       // TODO: make private
-       type    m_type;
-
-       // TODO: make private, switch to std::string
-       mutable tu_string       m_string_value;
-
-       // TODO: make private
-       union
-       {
-               bool m_boolean_value;
-               // @@ hm, what about PS2, where double is bad?  should maybe 
have int&float types.
-               mutable double  m_number_value;
-               as_object*      m_object_value;
-               as_c_function_ptr       m_c_function_value;
-               as_function*    m_as_function_value;
-       };
-
        /// Construct an UNDEFINED value
        as_value()
                :
@@ -415,6 +398,24 @@
        void    string_concat(const tu_string& str);
 
        tu_string* get_mutable_tu_string() { assert(m_type == STRING); return 
&m_string_value; }
+
+private:
+
+       type    m_type;
+
+       // TODO: switch to std::string
+       mutable tu_string       m_string_value;
+
+       union
+       {
+               bool m_boolean_value;
+               // @@ hm, what about PS2, where double is bad?  should maybe 
have int&float types.
+               mutable double  m_number_value;
+               as_object*      m_object_value;
+               as_c_function_ptr       m_c_function_value;
+               as_function*    m_as_function_value;
+       };
+
 };
 
 inline std::ostream& operator<< (std::ostream& os, const as_value& v) {