[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] gnash ChangeLog gui/gtk.cpp gui/gtksup.h
From: |
strk |
Subject: |
Re: [Gnash-commit] gnash ChangeLog gui/gtk.cpp gui/gtksup.h |
Date: |
Wed, 10 Jan 2007 15:29:07 +0100 |
On Wed, Jan 10, 2007 at 02:17:34PM +0000, Bastiaan Jacques wrote:
> -namespace {
> -gnash::LogFile& dbglogfile = gnash::LogFile::getDefaultInstance();
> +namespace gnash {
> +LogFile& dbglogfile = gnash::LogFile::getDefaultInstance();
> }
The "anonymous" namespace approach seems to be a C++ style
of module-statics. If you use 'gnash' namespace, you then need
to make it static or might eventually clash with other 'dbglogfile'
symbols in other modules. I'm for keeping the anonymous namespace
instead.
--strk;