[Gnash-commit] gnash ChangeLog server/asobj/NetStream.cpp test...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/01/12 09:35:58

Modified files:
        .              : ChangeLog 
        server/asobj   : NetStream.cpp 
        testsuite/actionscript.all: NetStream.as 

Log message:
                * testsuite/actionscript.all/NetStream.as: don't check 
unavailability
                  of the class based on SWF version as the player is allowed to
                  provide new classes reguardless of it. Use typeof to strictly 
check
                  methods existance, check case-sensitiveness of methods.
                * server/asobj/NetStream.cpp: fix case of methods.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.2092&r2=1.2093
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/NetStream.cpp?cvsroot=gnash&r1=1.20&r2=1.21
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/NetStream.as?cvsroot=gnash&r1=1.7&r2=1.8

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.2092
retrieving revision 1.2093
diff -u -b -r1.2092 -r1.2093
--- ChangeLog   12 Jan 2007 09:25:33 -0000      1.2092
+++ ChangeLog   12 Jan 2007 09:35:58 -0000      1.2093
@@ -1,5 +1,10 @@
 2007-01-12 Sandro Santilli <address@hidden>
 
+       * testsuite/actionscript.all/NetStream.as: don't check unavailability
+         of the class based on SWF version as the player is allowed to
+         provide new classes reguardless of it. Use typeof to strictly check
+         methods existance, check case-sensitiveness of methods.
+       * server/asobj/NetStream.cpp: fix case of methods.
        * testsuite/actionscript.all/Makefile.am: add 'quickcheck'
          rule, running *one* gnash process for each version.
          Currently some tests fail, but that's likely due to

Index: server/asobj/NetStream.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/NetStream.cpp,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -b -r1.20 -r1.21
--- server/asobj/NetStream.cpp  7 Dec 2006 13:11:53 -0000       1.20
+++ server/asobj/NetStream.cpp  12 Jan 2007 09:35:58 -0000      1.21
@@ -18,7 +18,7 @@
 //
 //
 
-/* $Id: NetStream.cpp,v 1.20 2006/12/07 13:11:53 strk Exp $ */
+/* $Id: NetStream.cpp,v 1.21 2007/01/12 09:35:58 strk Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -48,7 +48,7 @@
     netstream_obj->set_member("pause", &netstream_pause);
     netstream_obj->set_member("play", &netstream_play);
     netstream_obj->set_member("seek", &netstream_seek);
-    netstream_obj->set_member("setbuffertime", &netstream_setbuffertime);
+    netstream_obj->set_member("setBufferTime", &netstream_setbuffertime);
 
     fn.result->set_as_object(netstream_obj);
 

Index: testsuite/actionscript.all/NetStream.as
===================================================================
RCS file: /sources/gnash/gnash/testsuite/actionscript.all/NetStream.as,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -b -r1.7 -r1.8
--- testsuite/actionscript.all/NetStream.as     10 Jan 2007 00:09:56 -0000      
1.7
+++ testsuite/actionscript.all/NetStream.as     12 Jan 2007 09:35:58 -0000      
1.8
@@ -20,30 +20,36 @@
 // compile this test case with Ming makeswf, and then
 // execute it like this gnash -1 -r 0 -v out.swf
 
-rcsid="$Id: NetStream.as,v 1.7 2007/01/10 00:09:56 strk Exp $";
+rcsid="$Id: NetStream.as,v 1.8 2007/01/12 09:35:58 strk Exp $";
 
 #include "check.as"
 
 #if OUTPUT_VERSION < 7
 
-check_equals(NetStream, undefined);
+// A Player version >= 7 can
+// still provide the class, altought limiting it's use
+//check_equals(typeof(NetStream), undefined);
 
 #else // OUTPUT_VERSION >= 7
 
+check_equals(typeof(NetStream), 'function');
+
 var netstreamObj = new NetStream;
 
 // test the NetStream constuctor
-check (netstreamObj != undefined);
+check_equals ( typeof(netstreamObj), 'object' );
 
 // test the NetStream::close method
-check (netstreamObj.close != undefined);
+check_equals ( typeof(netstreamObj.close), 'function' );
 // test the NetStream::pause method
-check (netstreamObj.pause != undefined);
+check_equals ( typeof(netstreamObj.pause), 'function' );
 // test the NetStream::play method
-check (netstreamObj.play != undefined);
+check_equals ( typeof(netstreamObj.play), 'function');
 // test the NetStream::seek method
-check (netstreamObj.seek != undefined);
-// test the NetStream::setbuffertime method
-check (netstreamObj.setbuffertime != undefined);
+check_equals ( typeof(netstreamObj.seek), 'function' );
+// test the NetStream::setBufferTime method
+check_equals ( typeof(netstreamObj.setBufferTime), 'function');
+// SWF7 up is case-sensitive !
+check_equals ( typeof(netstreamObj.setbuffertime), 'undefined');
 
 #endif // OUTPUT_VERSION >= 7