gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog backend/render_handler.h libgeo...


From: strk
Subject: Re: [Gnash-commit] gnash ChangeLog backend/render_handler.h libgeo...
Date: Thu, 1 Mar 2007 14:24:16 +0100

On Thu, Mar 01, 2007 at 11:06:32AM +0000, Udo Giacomozzi wrote:

>    virtual bool bounds_in_clipping_area(const InvalidatedRanges& ranges) {
> -     for (int rno=0; rno<ranges.size(); rno++) 
> +     for (unsigned int rno=0; rno<ranges.size(); rno++) 
>               if (bounds_in_clipping_area(ranges.getRange(rno)))
>                       return true;

This was the reason to provide a 'visitor' model for SnappingRanges2d, hiding
the underlying container type. This use uses a random access iterator when
it doesn't even need to. For a source-level compatibility with future container
switch we could expose the iterator interface, or provide the visitor pattern.

Yest another possibility (the cleanset) would be to do everything inside 
SnappingTRanges,
as I see _clipbounds are basically a SnappingRange2d now (right?)

--strk;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]