Re[2]: [Gnash-commit] gnash ChangeLog backend/render_handler_agg.cpp

[Udo Giacomozzi]

Hello strk,

Wednesday, June 6, 2007, 3:38:56 PM, you wrote:

s> On Wed, Jun 06, 2007 at 01:24:52PM +0000, Udo Giacomozzi wrote:
>>      // NOTE: Assuming that the source image is RGB 8:8:8
>>      
>> @@ -445,6 +447,9 @@
>>    
>>      image::rgb* frame = static_cast<image::rgb*>(baseframe);

s> If the NOTE and the static_cast are related,

Yes and no. The note is about the pixel format (24 bit and not 15 or
16 or whatever bits). But it also assumes RGB, not YUV. However,
videoFrameFormat() tells the core that the renderer needs RGB data.


s> consider adding an assertion
s> above the static cast:

s>         assert(dynamic_cast<image::rgb*>(baseframe));


Ok, added.


s> I guess this is one of those "caches" preventing multiple renderers in
s> a single run...

It's not a cache. Don't know if the core continously calls
videoFrameFormat(). In that case there would be no problem.

Udo