Re: [Gnash-commit] gnash ChangeLog backend/sound_handler.cpp backe...

[Tomas Groth]

--- strk <address@hidden> skrev:

> On Thu, Jun 07, 2007 at 12:10:21PM +0000, Tomas Groth wrote:
> 
> >     std::auto_ptr<image::image_base> ret_image;
> >  
> >     if (outputFormat == YUV) {
> >             ret_image.reset(new image::yuv(width, height));
> >     } else if (outputFormat == RGB) {
> >             ret_image.reset(new image::rgb(width, height));
> > +   } else {
> > +           ret_image.reset(NULL);
> 
>       log_error("Unknown outputFormat %d during decoding ..."); ? 
> 
> > +           return ret_image;
> > +   }
> 
> 
> Question: why do we opt between RGB and YUV ? Do we do this also for other
>           kind of bitmaps (glyphs, whatever...) ? is any renderer using YUV ?
>         Could we have the renderer provide an "hint" but then accept any
>         of the two formats ?
> 

I guess it originate back to when the OpenGL backend was doing the YUV->RGB
conversion itself (which never really worked), and it just stayed... Both AGG
and GL now uses RGB, but i think i understood that Cairo might prefer RGBA,
which i believe we could then convert to when cairo gets up to speed.
About what the renderers can and can't do, i'm not too sure about... 

cheers,

Tomas