[Gnash-commit] gnash ChangeLog testsuite/MovieTester.h testsui...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/06/07 12:35:21

Modified files:
        .              : ChangeLog 
        testsuite      : MovieTester.h 
        testsuite/misc-ming.all: Video-EmbedSquareTestRunner.cpp 

Log message:
                * testsuite/MovieTester.h: add a canTestRendering() method.
                * testsuite/misc-ming.all/Video-EmbedSquareTestRunner.cpp:
                  Don't run the pixel checking part if MovieTester can't test
                  rendering. Raise an UNTESTED label instead, so it's reported.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.3481&r2=1.3482
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/MovieTester.h?cvsroot=gnash&r1=1.25&r2=1.26
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-ming.all/Video-EmbedSquareTestRunner.cpp?cvsroot=gnash&r1=1.3&r2=1.4

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.3481
retrieving revision 1.3482
diff -u -b -r1.3481 -r1.3482
--- ChangeLog   7 Jun 2007 12:24:34 -0000       1.3481
+++ ChangeLog   7 Jun 2007 12:35:20 -0000       1.3482
@@ -1,3 +1,10 @@
+2007-06-06 Sandro Santilli <address@hidden>
+
+       * testsuite/MovieTester.h: add a canTestRendering() method.
+       * testsuite/misc-ming.all/Video-EmbedSquareTestRunner.cpp: 
+         Don't run the pixel checking part if MovieTester can't test
+         rendering. Raise an UNTESTED label instead, so it's reported.
+
 2007-06-07 Sandro Santilli <address@hidden>
 
        * libgeometry/snappingrange.h: initialize all members in the

Index: testsuite/MovieTester.h
===================================================================
RCS file: /sources/gnash/gnash/testsuite/MovieTester.h,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -b -r1.25 -r1.26
--- testsuite/MovieTester.h     6 Jun 2007 13:18:53 -0000       1.25
+++ testsuite/MovieTester.h     7 Jun 2007 12:35:21 -0000       1.26
@@ -228,6 +228,14 @@
        ///
        bool canTestSound() const { return _sound_handler.get() != NULL; }
 
+       /// Return true if this build of MovieTester supports pixel checking 
+       //
+       /// Pixel checking will be supported as long as a testing-capable 
render handler
+       /// was compiled in. Testing-capable means capable of off-screen 
rendering, which
+       /// is implementing the render_handler::initTestBuffer method.
+       ///
+       bool canTestRendering() const { return ! _testingRenderers.empty(); }
+
 private:
 
        /// Initialize testing renderers

Index: testsuite/misc-ming.all/Video-EmbedSquareTestRunner.cpp
===================================================================
RCS file: 
/sources/gnash/gnash/testsuite/misc-ming.all/Video-EmbedSquareTestRunner.cpp,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -b -r1.3 -r1.4
--- testsuite/misc-ming.all/Video-EmbedSquareTestRunner.cpp     5 Jun 2007 
14:40:00 -0000       1.3
+++ testsuite/misc-ming.all/Video-EmbedSquareTestRunner.cpp     7 Jun 2007 
12:35:21 -0000       1.4
@@ -46,6 +46,12 @@
        sprite_instance* root = tester.getRootMovie();
        assert(root);
 
+       if ( ! tester.canTestRendering() )
+       {
+               cout << "UNTESTED: rendering can't be tested with this build." 
<< endl;
+               return EXIT_SUCCESS; // so testing doesn't abort
+       } 
+
        rgba red(255,0,0,255);
        rgba yellow(255,255,0,255);