[Gnash-commit] gnash ChangeLog server/parser/movie_def_impl.h ...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/06/18 09:33:06

Modified files:
        .              : ChangeLog 
        server/parser  : movie_def_impl.h movie_definition.h 
                         sprite_definition.h 

Log message:
                * server/parser/: movie_def_impl.h, movie_definition.h,
                  sprite_definition.h: document add_execute_tag ownership
                  transfer.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.3576&r2=1.3577
http://cvs.savannah.gnu.org/viewcvs/gnash/server/parser/movie_def_impl.h?cvsroot=gnash&r1=1.46&r2=1.47
http://cvs.savannah.gnu.org/viewcvs/gnash/server/parser/movie_definition.h?cvsroot=gnash&r1=1.25&r2=1.26
http://cvs.savannah.gnu.org/viewcvs/gnash/server/parser/sprite_definition.h?cvsroot=gnash&r1=1.22&r2=1.23

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.3576
retrieving revision 1.3577
diff -u -b -r1.3576 -r1.3577
--- ChangeLog   18 Jun 2007 08:56:36 -0000      1.3576
+++ ChangeLog   18 Jun 2007 09:33:05 -0000      1.3577
@@ -1,3 +1,9 @@
+2007-06-18 Sandro Santilli <address@hidden>
+
+       * server/parser/: movie_def_impl.h, movie_definition.h,
+         sprite_definition.h: document add_execute_tag ownership
+         transfer.
+
 2007-06-18 Zou Lunkai <address@hidden>
 
        * testsuite/misc-ming.all/shape_test.c: more tests, make the deduction 
easier.

Index: server/parser/movie_def_impl.h
===================================================================
RCS file: /sources/gnash/gnash/server/parser/movie_def_impl.h,v
retrieving revision 1.46
retrieving revision 1.47
diff -u -b -r1.46 -r1.47
--- server/parser/movie_def_impl.h      17 Jun 2007 09:07:27 -0000      1.46
+++ server/parser/movie_def_impl.h      18 Jun 2007 09:33:06 -0000      1.47
@@ -470,12 +470,12 @@
        // See dox in movie_definition.h
        int get_loading_sound_stream_id() { return m_loading_sound_stream; }
 
-       /// Add an execute_tag to this movie_definition's playlist
-       void    add_execute_tag(execute_tag* e)
+       // See dox in movie_definition.h
+       void    add_execute_tag(execute_tag* tag)
        {
-           assert(e);
+           assert(tag);
            if (_frames_loaded < m_playlist.size()) {
-             m_playlist[_frames_loaded].push_back(e);
+             m_playlist[_frames_loaded].push_back(tag);
            }
        }
 

Index: server/parser/movie_definition.h
===================================================================
RCS file: /sources/gnash/gnash/server/parser/movie_definition.h,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -b -r1.25 -r1.26
--- server/parser/movie_definition.h    17 Jun 2007 09:07:27 -0000      1.25
+++ server/parser/movie_definition.h    18 Jun 2007 09:33:06 -0000      1.26
@@ -331,10 +331,18 @@
                return NULL;
        }
 
-       /// Add an execute_tag to the frame currently being loaded
+       /// Add an execute_tag to this movie_definition's playlist
        //
        /// The default implementation is a no-op.
        ///
+       /// @param tag
+       ///     The tag to add in the list of executable tags for
+       ///     the frame currently being loaded. Ownership is transferred
+       ///     to the movie_def_impl.
+       ///
+       /// TODO: take an auto_ptr.
+       /// NOTE: the default implementation just let the execute_tag leak.
+       ///
        virtual void    add_execute_tag(execute_tag* /*c*/)
        {
        }

Index: server/parser/sprite_definition.h
===================================================================
RCS file: /sources/gnash/gnash/server/parser/sprite_definition.h,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -b -r1.22 -r1.23
--- server/parser/sprite_definition.h   17 Jun 2007 09:07:27 -0000      1.22
+++ server/parser/sprite_definition.h   18 Jun 2007 09:33:06 -0000      1.23
@@ -290,6 +290,7 @@
                character* parent, int id);
 
 
+       // See dox in movie_definition.h
        virtual void    add_execute_tag(execute_tag* c)
        {
                m_playlist[m_loading_frame].push_back(c);