[Gnash-commit] gnash ChangeLog server/edit_text_character.cpp ...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/06/29 06:05:59

Modified files:
        .              : ChangeLog 
        server         : edit_text_character.cpp edit_text_character.h 

Log message:
                * server/edit_text_character.{cpp,h}:
                  Do not call on_event(KILL_FOCUS) in the destructor, do
                  it on ::unload(). The less things destructors do, the better
                  (think GC..)

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.3616&r2=1.3617
http://cvs.savannah.gnu.org/viewcvs/gnash/server/edit_text_character.cpp?cvsroot=gnash&r1=1.69&r2=1.70
http://cvs.savannah.gnu.org/viewcvs/gnash/server/edit_text_character.h?cvsroot=gnash&r1=1.32&r2=1.33

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.3616
retrieving revision 1.3617
diff -u -b -r1.3616 -r1.3617
--- ChangeLog   28 Jun 2007 01:31:26 -0000      1.3616
+++ ChangeLog   29 Jun 2007 06:05:58 -0000      1.3617
@@ -1,3 +1,10 @@
+2007-06-28 Sandro Santilli <address@hidden>
+
+       * server/edit_text_character.{cpp,h}:
+         Do not call on_event(KILL_FOCUS) in the destructor, do
+         it on ::unload(). The less things destructors do, the better
+         (think GC..)
+
 2007-06-27 Petr Pisar <address@hidden>
 
        * po/: Makefile.am, cs.po: Initial Czech translation.

Index: server/edit_text_character.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/edit_text_character.cpp,v
retrieving revision 1.69
retrieving revision 1.70
diff -u -b -r1.69 -r1.70
--- server/edit_text_character.cpp      24 Jun 2007 12:58:28 -0000      1.69
+++ server/edit_text_character.cpp      29 Jun 2007 06:05:59 -0000      1.70
@@ -17,7 +17,7 @@
 // Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 //
 
-/* $Id: edit_text_character.cpp,v 1.69 2007/06/24 12:58:28 strk Exp $ */
+/* $Id: edit_text_character.cpp,v 1.70 2007/06/29 06:05:59 strk Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -368,6 +368,11 @@
 
 edit_text_character::~edit_text_character()
 {
+}
+
+void
+edit_text_character::unload()
+{
        // TODO: unregisterTextVariable() ?
        on_event(event_id::KILLFOCUS);
 }

Index: server/edit_text_character.h
===================================================================
RCS file: /sources/gnash/gnash/server/edit_text_character.h,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -b -r1.32 -r1.33
--- server/edit_text_character.h        15 Jun 2007 15:00:29 -0000      1.32
+++ server/edit_text_character.h        29 Jun 2007 06:05:59 -0000      1.33
@@ -102,6 +102,9 @@
        // See dox in character.h
        bool pointInShape(float x, float y) const;
 
+       // See dox in character.h
+       void unload();
+
 private:
 
        /// The actual text