[Gnash-commit] gnash ChangeLog server/parser/button_character_...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/06/29 20:37:51

Modified files:
        .              : ChangeLog 
        server/parser  : button_character_def.cpp 

Log message:
                * server/parser/button_character_def.cpp: ok, let action_buffer 
leak,
                  as it seems deleting them in button_action dtor introduces a
                  segfault in our testusuite. Sorry for not running 'make check'
                  before committing.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.3621&r2=1.3622
http://cvs.savannah.gnu.org/viewcvs/gnash/server/parser/button_character_def.cpp?cvsroot=gnash&r1=1.14&r2=1.15

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.3621
retrieving revision 1.3622
diff -u -b -r1.3621 -r1.3622
--- ChangeLog   29 Jun 2007 09:29:00 -0000      1.3621
+++ ChangeLog   29 Jun 2007 20:37:51 -0000      1.3622
@@ -1,3 +1,10 @@
+2007-06-29 Sandro Santilli <address@hidden>
+
+       * server/parser/button_character_def.cpp: ok, let action_buffer leak,
+         as it seems deleting them in button_action dtor introduces a
+         segfault in our testusuite. Sorry for not running 'make check'
+         before committing.
+
 2007-06-29 Udo Giacomozzi <address@hidden>
 
        * gui/gtk_glue_agg.cpp: properly initialize new SHM variables

Index: server/parser/button_character_def.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/parser/button_character_def.cpp,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -b -r1.14 -r1.15
--- server/parser/button_character_def.cpp      29 Jun 2007 06:31:46 -0000      
1.14
+++ server/parser/button_character_def.cpp      29 Jun 2007 20:37:51 -0000      
1.15
@@ -17,7 +17,7 @@
 // Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 //
 
-/* $Id: button_character_def.cpp,v 1.14 2007/06/29 06:31:46 strk Exp $ */
+/* $Id: button_character_def.cpp,v 1.15 2007/06/29 20:37:51 strk Exp $ */
 
 // Based on the public domain work of Thatcher Ulrich <address@hidden> 2003
 
@@ -41,7 +41,17 @@
        for (ActionList::iterator i=m_actions.begin(), e=m_actions.end();
                        i != e; ++i)
        {
-               delete (*i);
+               // We can NOT delete action_buffers here becase they 
+               // may contain the action currently being executed and
+               // triggering the deletion.
+               // I'm not really sure about whether this is the problem,
+               // anyway clip_as_button2.swf fails on segfault when clicking
+               // the upper-right button if we delete here.
+               //
+               // TODO: properly implement management of these resources
+               //       which are otherwise just leaking..
+               //
+               //delete (*i);
        }
        m_actions.clear(); // this is useless, will be done automatically
 }