[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] gnash/testsuite/misc-ming.all opcode_guard_test.c
From: |
strk |
Subject: |
Re: [Gnash-commit] gnash/testsuite/misc-ming.all opcode_guard_test.c |
Date: |
Thu, 27 Sep 2007 07:28:08 +0200 |
Zou, re-introducing the opcode-guard gives me 3 XPASS, which are
the ones I just changed from check to xcheck when removed the opcode-guard.
This i to say that we lack a test failing for the curveball.swf and feed.swf
cases, which are instead fixed by removing the opcode guard.
I belive Company told once that removed sprites get properties cleared.
_root is known to be a proper property so it might be reomved as well,
in which case the '_root.checkXX' calls would be no-ops.
This is the reason why I added the total expected number of tests run,
which we should add to the misc-ming.all subdir too.
I'll try to look more closely at feed.swf and/or curveball.swf to find
out more about those cases, but for now I don't have any real-world testcase
failing due to the missing opcode-guard.
--strk;
On Thu, Sep 27, 2007 at 04:44:02AM +0000, Zou Lunkai wrote:
> CVSROOT: /sources/gnash
> Module name: gnash
> Changes by: Zou Lunkai <zoulunkai> 07/09/27 04:44:02
>
> Modified files:
> testsuite/misc-ming.all: opcode_guard_test.c
>
> Log message:
>
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-ming.all/opcode_guard_test.c?cvsroot=gnash&r1=1.1&r2=1.2
>
> Patches:
> Index: opcode_guard_test.c
> ===================================================================
> RCS file: /sources/gnash/gnash/testsuite/misc-ming.all/opcode_guard_test.c,v
> retrieving revision 1.1
> retrieving revision 1.2
> diff -u -b -r1.1 -r1.2
> --- opcode_guard_test.c 27 Sep 2007 04:40:24 -0000 1.1
> +++ opcode_guard_test.c 27 Sep 2007 04:44:02 -0000 1.2
> @@ -57,7 +57,7 @@
>
>
> mc1 = newSWFMovieClip();
> - // should be executed.
> + // should not be executed.
> add_clip_actions(mc1, "_root.xcheck(false);");
> SWFMovieClip_nextFrame(mc1);
>
>
>
> _______________________________________________
> Gnash-commit mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnash-commit
--
() ASCII Ribbon Campaign
/\ Keep it simple!