[Gnash-commit] gnash ChangeLog server/sprite_instance.cpp

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/10/03 07:52:47

Modified files:
        .              : ChangeLog 
        server         : sprite_instance.cpp 

Log message:
                * server/sprite_instance.cpp (unload): clear the drawable when 
unload
                  (won't be needed anymore).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.4503&r2=1.4504
http://cvs.savannah.gnu.org/viewcvs/gnash/server/sprite_instance.cpp?cvsroot=gnash&r1=1.363&r2=1.364

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.4503
retrieving revision 1.4504
diff -u -b -r1.4503 -r1.4504
--- ChangeLog   3 Oct 2007 07:24:35 -0000       1.4503
+++ ChangeLog   3 Oct 2007 07:52:46 -0000       1.4504
@@ -1,5 +1,7 @@
 2007-10-03 Sandro Santilli <address@hidden>
 
+       * server/sprite_instance.cpp (unload): clear the drawable when unload
+         (won't be needed anymore).
        * server/sprite_instance.cpp: add support for debugging the drawing
          API.
 

Index: server/sprite_instance.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/sprite_instance.cpp,v
retrieving revision 1.363
retrieving revision 1.364
diff -u -b -r1.363 -r1.364
--- server/sprite_instance.cpp  3 Oct 2007 07:24:36 -0000       1.363
+++ server/sprite_instance.cpp  3 Oct 2007 07:52:47 -0000       1.364
@@ -2188,6 +2188,11 @@
                }
        }
 
+       // TODO: if this was UNLOAD release as much memory as possible ?
+       //       Verify if this is possible, in particular check order in
+       //       which unload handlers of parent and childs is performed
+       //       and wheter unload of child can access members of parent.
+
        testInvariant();
 
        return called;
@@ -3438,8 +3443,10 @@
        // We won't be displayed again, so worth releasing
        // some memory. The drawable might take a lot of memory
        // on itself.
-       //_drawable.clear();
+       _drawable->clear();
        // TODO: drop the _drawable_inst too ?
+       //       it would require _drawable_inst to possibly be NULL,
+       //       which wouldn't be bad at all actually...
 
        return character::unload() || childHaveUnloadHandler;