[Gnash-commit] gnash ChangeLog server/swf/tag_loaders.cpp

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/10/19 14:02:13

Modified files:
        .              : ChangeLog 
        server/swf     : tag_loaders.cpp 

Log message:
                * server/swf/tag_loaders.cpp (file_attributes_loader):
                  Update message and add TODO list based on a talk with
                  Benjamin Otte on #gnash.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.4648&r2=1.4649
http://cvs.savannah.gnu.org/viewcvs/gnash/server/swf/tag_loaders.cpp?cvsroot=gnash&r1=1.148&r2=1.149

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.4648
retrieving revision 1.4649
diff -u -b -r1.4648 -r1.4649
--- ChangeLog   19 Oct 2007 13:50:24 -0000      1.4648
+++ ChangeLog   19 Oct 2007 14:02:12 -0000      1.4649
@@ -1,5 +1,11 @@
 2007-10-19 Sandro Santilli <address@hidden>
 
+       * server/swf/tag_loaders.cpp (file_attributes_loader):
+         Update message and add TODO list based on a talk with
+         Benjamin Otte on #gnash.
+
+2007-10-19 Sandro Santilli <address@hidden>
+
        * libmedia/VideoDecoder.h: add getPaddingBytes.
        * libmedia/sdl/VideoDecoderFfmpeg.h: implement getPaddingBytes
          using the ffmpeg define.

Index: server/swf/tag_loaders.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/swf/tag_loaders.cpp,v
retrieving revision 1.148
retrieving revision 1.149
diff -u -b -r1.148 -r1.149
--- server/swf/tag_loaders.cpp  19 Oct 2007 12:17:28 -0000      1.148
+++ server/swf/tag_loaders.cpp  19 Oct 2007 14:02:13 -0000      1.149
@@ -17,7 +17,7 @@
 // Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 //
 
-/* $Id: tag_loaders.cpp,v 1.148 2007/10/19 12:17:28 strk Exp $ */
+/* $Id: tag_loaders.cpp,v 1.149 2007/10/19 14:02:13 strk Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -1459,11 +1459,16 @@
     {
        log_unimpl(_("FileAttributes tag in the SWF requests that "
                    "network access is not granted to this movie "
-                   "(or application?). Anyway Gnash won't care; "
+                   "(or application?) when loaded from the filesystem. "
+                   "Anyway Gnash won't care; "
                    "use white/black listing in your .gnashrc instead"));
     }
 
-    // TODO: attach info to movie_definition
+    // TODO:
+    //         - attach info to movie_definition.
+    //         - don't allow later FileAttributes tags in the same movie
+    //           to override the first one used.
+    //         - only use if it is the *first* tag in the stream.
 }
 
 void