Re: [Gnash-commit] gnash Makefile.am configure.ac ChangeLog gui/Ma...

[strk]

On Thu, Nov 22, 2007 at 04:19:57PM +0000, Rob Savoye wrote:

> +if test x"${build_alp}" = xyes; then
> +  GNASH_PATH_ALP
> +  if test x"${have_alp}" = x"yes"; then
> +    AC_DEFINE([HAVE_ALP], [], [Access Linux Platform framework])
> +  fi
> +  cross_compiling=yes
> +  build_gtk=yes
> +  build_kde=no
> +  build_ogl=no
> +  build_agg=yes
> +fi

Is ALP incompatible with kde/ogl ?
Should we print a warning whenever
we disable something the user requested 
or we force enable something else ?

> +if test x$build_hildon = xyes; then
> +  GNASH_PATH_HILDON
> +  build_gtk=yes
> +  build_kde=no
> +dnl   build_ogl=no
> +dnl   build_agg=yes
> +fi

Same here.

>  dnl TODO: add checks for all other GUIs
>  
>  
> @@ -1091,6 +1139,8 @@
>    AC_MSG_WARN(["Enabled KPARTS plugin, but you aren't building a KDE based 
> GUI!"])
>  fi
>  
> +AM_CONDITIONAL(BUILD_ALP_GUI, [ test x$build_alp = xyes ])
> +AM_CONDITIONAL(BUILD_HILDON_GUI, [ test x$build_hildon = xyes ])
>  AM_CONDITIONAL(BUILD_GTK_GUI, [ test x$build_gtk = xyes ])
>  AM_CONDITIONAL(BUILD_KDE_GUI, [ test x$build_kde = xyes ])
>  dnl AM_CONDITIONAL(BUILD_QT_GUI, [ test x$build_qt = xyes ])
> @@ -1787,6 +1837,24 @@
>    fi
>  fi
>  
> +
> +if test x$build_hildon = xyes; then #{
> +  if test x"$HILDON_LIBS" != x; then
> +    if test x"$HILDON_CFLAGS" != x; then
> +      echo "        HILDON flags are: $HILDON_CFLAGS"
> +    else
> +      echo "        HILDON flags are: default include path"
> +    fi
> +      echo "        HILDON libs are: $HILDON_LIBS"
> +  else
> +    echo "        ERROR: No HILDON development package installed!"
> +    echo "               Install it from http://gtk.org";
> +    echo "               or .deb users: apt-get install libhildon.0-dev"
> +    echo "               or .rpm users: yum install hildon-devel"
> +dnl    nogo=true

Why not a nogo ?

> +dnl Access Linux Platform
> +if test x"${build_alp}" = xyes; then
> +  if test x"${ALP_CFLAGS}" != x; then
> +    echo "        ALP flags are: $ALP_CFLAGS"
> +    echo "        ALP libs are: $ALP_LIBS"
> +  else
> +    echo "        ERROR: No ALP development package is installed."
> +  fi
> +fi

Why not a nogo ?

--strk;