gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash/server/vm ASHandlers.cpp


From: strk
Subject: Re: [Gnash-commit] gnash/server/vm ASHandlers.cpp
Date: Fri, 23 Nov 2007 08:13:21 +0100

On Fri, Nov 23, 2007 at 02:37:39AM +0000, Zou Lunkai wrote:

> +    // No need to use to_string_versioned() here, this is a swf7 opcode
>      env.top(1).set_bool(env.top(1).to_string() > env.top(0).to_string());

That's not a safe assumption. Better call to_string_versioned() as the
caller should only know about interfaces, not how they are implemented.

--strk;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]