Re: [Gnash-commit] gnash ChangeLog plugin/plugin.cpp

[strk]

On Mon, Dec 17, 2007 at 01:15:50PM +0000, Benjamin Wolsey wrote:
> CVSROOT:      /sources/gnash
> Module name:  gnash
> Changes by:   Benjamin Wolsey <bwy>   07/12/17 13:15:50
> 
> Modified files:
>       .              : ChangeLog 
>       plugin         : plugin.cpp 
> 
> Log message:
>               * plugin/plugin.cpp: change NPAPI error messages so as not to
>                 annoy Opera users (doesn't make it work on Opera, 
> unfortunately),
>                 general code cleanup.


Rather then defining argv as an array to non-const char pointers:

>      char **argv = new char *[maxargc];

Wouldn't it be better to define as an array to const ones ?

> +     argv[argc++] = const_cast<char*>("-v");
> +     argv[argc++] = const_cast<char*>("-x");
> +     argv[argc++] = const_cast<char*>("-j");
> +     argv[argc++] = const_cast<char*>("-k");
> +     argv[argc++] = const_cast<char*>("-u");
> +             argv[argc++] = const_cast<char*> ("-U");
>       argv[argc++] = const_cast<char*>( pageurl );

All the const_cast above would go

--strk;