[Gnash-commit] gnash ChangeLog libamf/amf.cpp libamf/amf.h

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/12/19 21:04:11

Modified files:
        .              : ChangeLog 
        libamf         : amf.cpp amf.h 

Log message:
        createElement: take element names by const refs.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.5222&r2=1.5223
http://cvs.savannah.gnu.org/viewcvs/gnash/libamf/amf.cpp?cvsroot=gnash&r1=1.46&r2=1.47
http://cvs.savannah.gnu.org/viewcvs/gnash/libamf/amf.h?cvsroot=gnash&r1=1.25&r2=1.26

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.5222
retrieving revision 1.5223
diff -u -b -r1.5222 -r1.5223
--- ChangeLog   19 Dec 2007 20:40:30 -0000      1.5222
+++ ChangeLog   19 Dec 2007 21:04:10 -0000      1.5223
@@ -1,5 +1,10 @@
 2007-12-19 Sandro Santilli <address@hidden>
 
+       * libamf/amf.{cpp,h} (createElement): take element names by
+         const refs.
+
+2007-12-19 Sandro Santilli <address@hidden>
+
        * server/as_value.{cpp,h}: turn SpriteProxy to a generic
          CharacterProxy, keep all characters by soft-refs.
        * server/character.h: expose a getOrigTarget and provide

Index: libamf/amf.cpp
===================================================================
RCS file: /sources/gnash/gnash/libamf/amf.cpp,v
retrieving revision 1.46
retrieving revision 1.47
diff -u -b -r1.46 -r1.47
--- libamf/amf.cpp      19 Dec 2007 19:40:21 -0000      1.46
+++ libamf/amf.cpp      19 Dec 2007 21:04:11 -0000      1.47
@@ -760,7 +760,7 @@
 
 AMF::amf_element_t *
 AMF::createElement(amf_element_t *el, astype_e type,
-                 std::string &name, uint8_t *data, int nbytes)
+                 const std::string &name, uint8_t *data, int nbytes)
 {
 //    GNASH_REPORT_FUNCTION;
     log_debug("Creating element %s", name.c_str());
@@ -781,7 +781,7 @@
 }
 
 AMF::amf_element_t *
-AMF::createElement(amf_element_t *el, std::string &name, amfnum_t data)
+AMF::createElement(amf_element_t *el, const std::string &name, amfnum_t data)
 {
     GNASH_REPORT_FUNCTION;
     log_debug("Creating element %s", name.c_str());
@@ -806,7 +806,7 @@
 }
 
 AMF::amf_element_t *
-AMF::createElement(amf_element_t *el, std::string &name, double data)
+AMF::createElement(amf_element_t *el, const std::string &name, double data)
 {
     GNASH_REPORT_FUNCTION;
     log_debug("Creating element %s", name.c_str());
@@ -837,7 +837,7 @@
 }
 
 AMF::amf_element_t *
-AMF::createElement(amf_element_t *el, std::string &name, std::string &data)
+AMF::createElement(amf_element_t *el, const std::string &name, std::string 
&data)
 {
     GNASH_REPORT_FUNCTION;
     log_debug("Creating element %s", name.c_str());
@@ -859,7 +859,7 @@
 }
 
 AMF::amf_element_t *
-AMF::createElement(AMF::amf_element_t *el, std::string &name, bool data)
+AMF::createElement(AMF::amf_element_t *el, const std::string &name, bool data)
 {
     GNASH_REPORT_FUNCTION;
     log_debug("Creating element %s", name.c_str());

Index: libamf/amf.h
===================================================================
RCS file: /sources/gnash/gnash/libamf/amf.h,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -b -r1.25 -r1.26
--- libamf/amf.h        19 Dec 2007 19:40:21 -0000      1.25
+++ libamf/amf.h        19 Dec 2007 21:04:11 -0000      1.26
@@ -230,28 +230,28 @@
     /// @ return an element all filled in correctly for passing to other
     /// methods.
     amf_element_t *createElement(amf_element_t *el, astype_e type,
-                                std::string &name, uint8_t *data, int nbytes);
-    amf_element_t *createElement(amf_element_t *el, std::string &name,
+                                const std::string &name, uint8_t *data, int 
nbytes);
+    amf_element_t *createElement(amf_element_t *el, const std::string &name,
                                 amfnum_t data);
     amf_element_t *createElement(amf_element_t *el, const char *name,
                                 double data);
-    amf_element_t *createElement(amf_element_t *el, std::string &name,
+    amf_element_t *createElement(amf_element_t *el, const std::string &name,
                                 double data);
     amf_element_t *createElement(amf_element_t *el, const char *name,
                                 amfnum_t data);
-    amf_element_t *createElement(amf_element_t *el, std::string &name,
+    amf_element_t *createElement(amf_element_t *el, const std::string &name,
                                 std::string &data);
     amf_element_t *createElement(amf_element_t *el, const char *name,
                                 const char *data);
-    amf_element_t *createElement(amf_element_t *el, std::string &name,
+    amf_element_t *createElement(amf_element_t *el, const std::string &name,
                                 bool data);
     amf_element_t *createElement(amf_element_t *el, const char *name,
                                 bool data);
-    amf_element_t *createElement(amf_element_t *el, std::string &name,
+    amf_element_t *createElement(amf_element_t *el, const std::string &name,
                                  boost::intrusive_ptr<gnash::as_object> &data);
     amf_element_t *createElement(amf_element_t *el, const char *name,
                                 boost::intrusive_ptr<gnash::as_object> &data);
-//     amf_element_t *createElement(amf_element_t *el, std::string &name,
+//     amf_element_t *createElement(amf_element_t *el, const std::string &name,
 //                              const gnash::as_value &data);
 //     amf_element_t *createElement(amf_element_t *el, const char *name,
 //                              const gnash::as_value &data);