[Gnash-commit] gnash ChangeLog server/asobj/xmlnode.cpp testsu...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/12/20 23:29:04

Modified files:
        .              : ChangeLog 
        server/asobj   : xmlnode.cpp 
        testsuite/actionscript.all: XML.as 

Log message:
        XMLNode attributes are note instances of Object class.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.5232&r2=1.5233
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/xmlnode.cpp?cvsroot=gnash&r1=1.41&r2=1.42
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/XML.as?cvsroot=gnash&r1=1.51&r2=1.52

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.5232
retrieving revision 1.5233
diff -u -b -r1.5232 -r1.5233
--- ChangeLog   20 Dec 2007 22:37:12 -0000      1.5232
+++ ChangeLog   20 Dec 2007 23:29:03 -0000      1.5233
@@ -1,5 +1,11 @@
 2007-12-20 Sandro Santilli <address@hidden>
 
+       * server/asobj/xmlnode.cpp: attributes are note instances
+         of Object class.
+       * testsuite/actionscript.all/XML.as: few more fixes.
+
+2007-12-20 Sandro Santilli <address@hidden>
+
        * server/asobj/xml.{cpp,h}: don't abort on XML.load() [ no args ].
          Engage a thread for each load request.
        * testsuite/actionscript.all/XML.as: the test is now sane, and

Index: server/asobj/xmlnode.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/xmlnode.cpp,v
retrieving revision 1.41
retrieving revision 1.42
diff -u -b -r1.41 -r1.42
--- server/asobj/xmlnode.cpp    20 Nov 2007 00:44:05 -0000      1.41
+++ server/asobj/xmlnode.cpp    20 Dec 2007 23:29:04 -0000      1.42
@@ -16,7 +16,7 @@
 // along with this program; if not, write to the Free Software
 // Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 
-/* $Id: xmlnode.cpp,v 1.41 2007/11/20 00:44:05 cmusick Exp $ */
+/* $Id: xmlnode.cpp,v 1.42 2007/12/20 23:29:04 strk Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -635,7 +635,7 @@
     boost::intrusive_ptr<XMLNode> ptr = ensureType<XMLNode>(fn.this_ptr);
 
     XMLNode::AttribList& attrs = ptr->attributes();
-    boost::intrusive_ptr<as_object> ret = new as_object(getObjectInterface());
+    boost::intrusive_ptr<as_object> ret = new as_object(); // attributes are 
not Object types (getObjectInterface());
     for (XMLNode::AttribList::const_iterator it=attrs.begin(),
          itEnd=attrs.end(); it != itEnd; ++it) {
 

Index: testsuite/actionscript.all/XML.as
===================================================================
RCS file: /sources/gnash/gnash/testsuite/actionscript.all/XML.as,v
retrieving revision 1.51
retrieving revision 1.52
diff -u -b -r1.51 -r1.52
--- testsuite/actionscript.all/XML.as   20 Dec 2007 22:49:38 -0000      1.51
+++ testsuite/actionscript.all/XML.as   20 Dec 2007 23:29:04 -0000      1.52
@@ -20,7 +20,7 @@
 // compile this test case with Ming makeswf, and then
 // execute it like this gnash -1 -r 0 -v out.swf
 
-rcsid="$Id: XML.as,v 1.51 2007/12/20 22:49:38 strk Exp $";
+rcsid="$Id: XML.as,v 1.52 2007/12/20 23:29:04 strk Exp $";
 
 #include "check.as"
 //#include "dejagnu.as"
@@ -685,8 +685,8 @@
 
        //note("myxml.toString(): "+myxml.toString());
        check_equals(typeof(myxml.attributes), 'object');
-       xcheck(! myxml.attributes instanceof Object);
-       xcheck_equals(typeof(myxml.attributes.__proto__), 'undefined');
+       check(! myxml.attributes instanceof Object);
+       check_equals(typeof(myxml.attributes.__proto__), 'undefined');
 
        check(myxml.hasChildNodes());
        check_equals(myxml.nodeName, null);