[Gnash-commit] gnash ChangeLog testsuite/actionscript.all/Load...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  08/01/11 09:09:59

Modified files:
        .              : ChangeLog 
        testsuite/actionscript.all: LoadVars.as 
        testsuite/media: vars.txt 

Log message:
        test that labels placed after newlines (and non ampersend-terminated) 
are
        still used  (gnash fails)

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.5374&r2=1.5375
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/LoadVars.as?cvsroot=gnash&r1=1.16&r2=1.17
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/media/vars.txt?cvsroot=gnash&r1=1.1&r2=1.2

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.5374
retrieving revision 1.5375
diff -u -b -r1.5374 -r1.5375
--- ChangeLog   11 Jan 2008 08:50:14 -0000      1.5374
+++ ChangeLog   11 Jan 2008 09:09:58 -0000      1.5375
@@ -1,5 +1,13 @@
 2008-01-11 Sandro Santilli <address@hidden>
 
+       * testsuite/media/vars.txt: add a final variable label
+         after newlines and w/out a terminating ampersend.
+       * testsuite/actionscript.all/LoadVars.as: test that labels
+         placed after newlines (and non ampersend-terminated) are
+         still used !!.
+
+2008-01-11 Sandro Santilli <address@hidden>
+
        * server/vm/ASHandlers.cpp (ActionNewEquals): for SWF<=5
          always convert the input parameters to primitives.
        * testsuite/actionscript.all/String.as: success in

Index: testsuite/actionscript.all/LoadVars.as
===================================================================
RCS file: /sources/gnash/gnash/testsuite/actionscript.all/LoadVars.as,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -b -r1.16 -r1.17
--- testsuite/actionscript.all/LoadVars.as      21 Nov 2007 09:21:50 -0000      
1.16
+++ testsuite/actionscript.all/LoadVars.as      11 Jan 2008 09:09:59 -0000      
1.17
@@ -21,7 +21,7 @@
 // compile this test case with Ming makeswf, and then
 // execute it like this gnash -1 -r 0 -v out.swf
 
-rcsid="$Id: LoadVars.as,v 1.16 2007/11/21 09:21:50 cmusick Exp $";
+rcsid="$Id: LoadVars.as,v 1.17 2008/01/11 09:09:59 strk Exp $";
 
 #include "check.as"
 
@@ -34,6 +34,8 @@
 // test the LoadVars constuctor
 xcheck_equals (typeof(loadvarsObj), 'object');
 
+check_totals(2);
+
 #else // OUTPUT_VERSION >= 6
 
 check_equals(typeof(LoadVars), 'function');
@@ -44,22 +46,42 @@
 check_equals (typeof(loadvarsObj), 'object');
 
 // test the LoadVars::addrequestheader method
+check (LoadVars.prototype.hasOwnProperty('addRequestHeader'));
 check_equals (typeof(loadvarsObj.addRequestHeader), 'function');
+
 // test the LoadVars::decode method
+check (LoadVars.prototype.hasOwnProperty('decode'));
 check_equals (typeof(loadvarsObj.decode), 'function');
+
 // test the LoadVars::getbytesloaded method
+check (LoadVars.prototype.hasOwnProperty('getBytesLoaded'));
 check_equals (typeof(loadvarsObj.getBytesLoaded), 'function');
+
 // test the LoadVars::getbytestotal method
+check (LoadVars.prototype.hasOwnProperty('getBytesTotal'));
 check_equals (typeof(loadvarsObj.getBytesTotal), 'function');
+
 // test the LoadVars::load method
+check (LoadVars.prototype.hasOwnProperty('load'));
 check_equals (typeof(loadvarsObj.load), 'function');
+
 // test the LoadVars::send method
+check (LoadVars.prototype.hasOwnProperty('send'));
 check_equals (typeof(loadvarsObj.send), 'function');
+
 // test the LoadVars::sendandload method
+check (LoadVars.prototype.hasOwnProperty('sendAndLoad'));
 check_equals (typeof(loadvarsObj.sendAndLoad), 'function');
+
 // test the LoadVars::tostring method
+check (LoadVars.prototype.hasOwnProperty('toString'));
 check_equals (typeof(loadvarsObj.toString), 'function');
 
+// test the LoadVars::tostring method
+check (!LoadVars.prototype.hasOwnProperty('valueOf'));
+check_equals (loadvarsObj.valueOf, Object.prototype.valueOf);
+check_equals (typeof(loadvarsObj.valueOf), 'function');
+
 //--------------------------------------------------------------------------
 // Test LoadVars::load()
 //--------------------------------------------------------------------------
@@ -92,6 +114,12 @@
                check_equals(loadvarsObj['var2'], 'val2');
                //check_equals(loadvarsObj['v2_var1'], 'val1');
                //check_equals(loadvarsObj['v2_var2'], 'val2');
+
+               // Gnash insists in looking for an ending & char !!             
+               xcheck_equals(loadvarsObj['var3'], 'val3\n');
+
+               check_totals(33);
+
                play();
        }
 };
@@ -136,4 +164,4 @@
 stop();
 
 #endif //  OUTPUT_VERSION >= 6
-totals();
+

Index: testsuite/media/vars.txt
===================================================================
RCS file: /sources/gnash/gnash/testsuite/media/vars.txt,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -b -r1.1 -r1.2
--- testsuite/media/vars.txt    23 Feb 2007 11:42:52 -0000      1.1
+++ testsuite/media/vars.txt    11 Jan 2008 09:09:59 -0000      1.2
@@ -32,3 +32,4 @@
 third line (should be discarded)
 third line (should be discarded)
 third line (should be discarded)
+&var3=val3