Re: [Gnash-commit] gnash ChangeLog server/asobj/SoundGst.cpp

[Bastiaan Jacques]

On Mon, 21 Jan 2008, Udo Giacomozzi wrote:

>         server/asobj/SoundGst.cpp: don't start playing sound in loadSound(), 
> always seek (allows replay of the same sound)

loadSound is documented that it should start playback when loading (this
is true at least if isStreaming is true). When isStreaming is false
(this is what docs refer to as an "event" sound I gather from your
commit it shouldn't be played back.

> Index: server/asobj/SoundGst.cpp
> ===================================================================
> RCS file: /cvsroot/gnash/gnash/server/asobj/SoundGst.cpp,v
> retrieving revision 1.16
> retrieving revision 1.17
> diff -u -b -r1.16 -r1.17
> --- server/asobj/SoundGst.cpp   21 Jan 2008 07:07:28 -0000      1.16
> +++ server/asobj/SoundGst.cpp   21 Jan 2008 11:04:35 -0000      1.17
> @@ -173,7 +173,7 @@
>
>         externalSound = true;
>
> -       start(0, 0);
> +  //start(0, 0);

so this should be:

if (isStreaming) {
  start(0,0);
}

Does that correspond with your testing?

Bastiaan