[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] gnash ChangeLog libbase/string_table.cpp libbas...
From: |
strk |
Subject: |
Re: [Gnash-commit] gnash ChangeLog libbase/string_table.cpp libbas... |
Date: |
Thu, 24 Jan 2008 09:25:47 +0100 |
On Thu, Jan 24, 2008 at 03:41:59AM +0000, Chad Musick wrote:
> CVSROOT: /sources/gnash
> Module name: gnash
> Changes by: Chad Musick <cmusick> 08/01/24 03:41:59
>
> Modified files:
> . : ChangeLog
> libbase : string_table.cpp string_table.h
> server : asClass.cpp asClass.h
>
> Log message:
> Add case-insensitive support for string_table. More work is needed to
> enable it where appropriate.
A suggestion could be not make sensitive-insensitive a per-call setting
but a permanent setting in string_table.
Currently, the only call to lower_next_group is at initialization time
(in namedStrings.cpp). Rather then call lower_next_group(), we may call
a setCaseInsensitive() method that would remember all lookups are
case-insensitive [if version < 7].
Then, PROPNAME would become a no-op, thus always keeping the case.
This should give us correct behaviour without too many further modifications.
What do you think ?
--strk;