AW: [Gnash-commit] gnash/server as_value.cpp

[Benjamin Wolsey]

>  
> +using namespace std;
> +
>  // Define the macro below to make abstract equality operator verbose
>  //#define GNASH_DEBUG_EQUALITY 1
>  

Using 'using namespace std' may be a matter of taste (I don't like it), but in 
code where *everything* is already nicely qualified it can't be ideal to be 
putting that in as well. As I understand the commit logs it's only for 
isfinite, which isn't part of the C++ standard in any case. For that reason I 
would think an ifdef would be more appropriate.

I may not be the only one who drops 'using namespace std' when I find no reason 
to be using it, and when such a person forgets why it's there, the line is 
quite likely doomed. A comment would prolong its life...

bwy




      Lesen Sie Ihre E-Mails auf dem Handy.
www.yahoo.de/go