Re: [Gnash-commit] gnash ChangeLog testsuite/actionscript.all/Obje...

[zou lunkai]

Just some comments:

+obj3.__proto__ = undefined;        <------ [1]
+check_equals(typeof(obj3), "object");
+xcheck_equals(obj3, undefined);   <----- [2]

since obj3.__proto__ is set to 'undefined', then both obj3.toString()
and obj3.valueOf() should give us 'undefined', so [2] should be passed
anyway.  Maybe __proto__ is protected in Gnash not be overridden?


--zou



On 3/26/08, Benjamin Wolsey <address@hidden> wrote:
> CVSROOT:        /sources/gnash
> Module name:    gnash
> Changes by:     Benjamin Wolsey <bwy>   08/03/25 21:28:23
>
> Modified files:
>        .              : ChangeLog
>        testsuite/actionscript.all: Object.as
>
> Log message:
>                * testsuite/actionscript.all/Object.as: test for
>                  Object.__proto__ = undefined; (Gnash fails)
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.6021&r2=1.6022
> http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/Object.as?cvsroot=gnash&r1=1.44&r2=1.45
>
> Patches:
> Index: ChangeLog
> ===================================================================
> RCS file: /sources/gnash/gnash/ChangeLog,v
> retrieving revision 1.6021
> retrieving revision 1.6022
> diff -u -b -r1.6021 -r1.6022
> --- ChangeLog   25 Mar 2008 16:23:09 -0000      1.6021
> +++ ChangeLog   25 Mar 2008 21:28:22 -0000      1.6022
> @@ -1,5 +1,10 @@
>  2008-03-25 Benjamin Wolsey <address@hidden>
>
> +       * testsuite/actionscript.all/Object.as: test for
> +         Object.__proto__ = undefined; (Gnash fails).
> +
> +2008-03-25 Benjamin Wolsey <address@hidden>
> +
>        * testsuite/actionscript.all/Global.as: more passes, some new
>          (now passing) tests for parseint.
>        * server/asobj/global.cpp: fix parseint, pass all actionscript.all
>
> Index: testsuite/actionscript.all/Object.as
> ===================================================================
> RCS file: /sources/gnash/gnash/testsuite/actionscript.all/Object.as,v
> retrieving revision 1.44
> retrieving revision 1.45
> diff -u -b -r1.44 -r1.45
> --- testsuite/actionscript.all/Object.as        11 Mar 2008 19:31:47 -0000    
>   1.44
> +++ testsuite/actionscript.all/Object.as        25 Mar 2008 21:28:23 -0000    
>   1.45
> @@ -21,7 +21,7 @@
>  // execute it like this gnash -1 -r 0 -v out.swf
>
>
> -rcsid="$Id: Object.as,v 1.44 2008/03/11 19:31:47 strk Exp $";
> +rcsid="$Id: Object.as,v 1.45 2008/03/25 21:28:23 bwy Exp $";
>  #include "check.as"
>
>  // Test existance of methods
> @@ -251,6 +251,10 @@
>  obj3.len2 = 'test';
>  check_equals (obj3.len2, 'test');
>
> +obj3.__proto__ = undefined;
> +check_equals(typeof(obj3), "object");
> +xcheck_equals(obj3, undefined);
> +
>  // TODO: try using the name of an existing property
>
>  // Try property inheritance
> @@ -547,6 +551,6 @@
>  #endif
>
>  #if OUTPUT_VERSION >= 6
> -totals(169);
> +totals(171);
>  #endif
>
>
>
> _______________________________________________
> Gnash-commit mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnash-commit
>