[Gnash-commit] gnash ChangeLog server/asobj/Global.cpp

[Benjamin Wolsey]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Benjamin Wolsey <bwy>   08/03/26 11:33:57

Modified files:
        .              : ChangeLog 
        server/asobj   : Global.cpp 

Log message:
                * server/asobj/Global.cpp: parseFloat should work with double
                  precision; improves swfdec testsuite results in parse-float.as
                  and string-to-number.as (though neither passes yet).
        
        string-to-number should be easy to fix; parse-float fails for the same 
reason
        as parse-int, i.e. __proto__ = undefined not correctly handled.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.6024&r2=1.6025
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/Global.cpp?cvsroot=gnash&r1=1.98&r2=1.99

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.6024
retrieving revision 1.6025
diff -u -b -r1.6024 -r1.6025
--- ChangeLog   26 Mar 2008 10:37:22 -0000      1.6024
+++ ChangeLog   26 Mar 2008 11:33:57 -0000      1.6025
@@ -1,3 +1,9 @@
+2008-03-26 Benjamin Wolsey <address@hidden>
+
+       * server/asobj/Global.cpp: parseFloat should work with double
+         precision; improves swfdec testsuite results in parse-float.as
+         and string-to-number.as (though neither passes yet). 
+
 2008-03-26 Sandro Santilli <address@hidden>
 
        * gui/sdl.cpp: fix sdl to gnash key modifiers conversion.

Index: server/asobj/Global.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/Global.cpp,v
retrieving revision 1.98
retrieving revision 1.99
diff -u -b -r1.98 -r1.99
--- server/asobj/Global.cpp     25 Mar 2008 16:23:10 -0000      1.98
+++ server/asobj/Global.cpp     26 Mar 2008 11:33:57 -0000      1.99
@@ -167,13 +167,15 @@
     return as_value(input.c_str());
 }
 
+// parseFloat(string)
+// The return value has double precision
 static as_value
 as_global_parsefloat(const fn_call& fn)
 {
     ASSERT_FN_ARGS_IS_1
 
     as_value rv;
-    float result;
+    double result;
     
     std::istringstream s(fn.arg(0).to_string());
     
@@ -183,10 +185,11 @@
         return rv;   
     }    
 
-    rv = static_cast<double>(result);
     return rv;
 }
 
+// parseInt(string[, base])
+//
 // The second argument, if supplied, is the base.
 // If none is supplied, we have to work out the 
 // base from the string. Decimal, octal and hexadecimal are