[Gnash-commit] gnash ChangeLog server/asobj/Global.cpp testsui...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  08/03/31 18:53:36

Modified files:
        .              : ChangeLog 
        server/asobj   : Global.cpp 
        testsuite/swfdec: PASSING 

Log message:
        clear flags of ASSetPropFlags default to 0, always, not to 1 in swf5
        (no idea where that idea came from).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.6124&r2=1.6125
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/Global.cpp?cvsroot=gnash&r1=1.105&r2=1.106
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/swfdec/PASSING?cvsroot=gnash&r1=1.113&r2=1.114

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.6124
retrieving revision 1.6125
diff -u -b -r1.6124 -r1.6125
--- ChangeLog   31 Mar 2008 17:17:14 -0000      1.6124
+++ ChangeLog   31 Mar 2008 18:53:35 -0000      1.6125
@@ -1,5 +1,12 @@
 2008-03-31 Sandro Santilli <address@hidden>
 
+       * server/asobj/Global.cpp (as_global_assetpropflags): clear flags
+         default to 0, always, not to 1 in swf5 (no idea where that idea came
+         from).
+       * testsuite/swfdec/PASSING: {string,function}-properties-5.swf pass.
+
+2008-03-31 Sandro Santilli <address@hidden>
+
        * server/builtin_function.h: Oops, swapped __constructor__
          and constructor..
        * server/asobj/Object.cpp: still register all property members,

Index: server/asobj/Global.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/Global.cpp,v
retrieving revision 1.105
retrieving revision 1.106
diff -u -b -r1.105 -r1.106
--- server/asobj/Global.cpp     31 Mar 2008 12:24:43 -0000      1.105
+++ server/asobj/Global.cpp     31 Mar 2008 18:53:35 -0000      1.106
@@ -402,8 +402,7 @@
 
     // ASSetPropFlags was exposed in Flash 5, however the fourth argument 
'set_false'
     // was not required as it always defaulted to the value '~0'. 
-    int set_false = (fn.nargs == 3 ? 
-                    (version == 5 ? ~0 : 0) : int(fn.arg(3).to_number()))
+    int set_false = (fn.nargs < 4 ? 0 : int(fn.arg(3).to_number()))
        & as_prop_flags::as_prop_flags_mask;
 
        obj->setPropFlags(props, set_false, set_true);

Index: testsuite/swfdec/PASSING
===================================================================
RCS file: /sources/gnash/gnash/testsuite/swfdec/PASSING,v
retrieving revision 1.113
retrieving revision 1.114
diff -u -b -r1.113 -r1.114
--- testsuite/swfdec/PASSING    31 Mar 2008 12:19:12 -0000      1.113
+++ testsuite/swfdec/PASSING    31 Mar 2008 18:53:36 -0000      1.114
@@ -245,6 +245,7 @@
 function-apply-crash-6.swf:d37c7e90d823363dcc4052167fcbb754
 function-apply-crash-7.swf:28334f00875b4d137083a98c13fbab87
 function-apply-crash-8.swf:d61b9cf7bb66862cb82e6b6f67ffe9d6
+function-properties-5.swf:45dd187e1d86f5d130ce22ea761531d0
 function-properties-6.swf:860c71e8d7dcc693ba95d0329c4ef084
 function-properties-7.swf:7100b7c2c31e05f85102669e7f054444
 function-properties-8.swf:fa1962a1efe9bfc01b652db45c8f4354
@@ -705,6 +706,7 @@
 stringlength-5.swf:bf014dcc64776fb859ff878286f56b16
 stringlength-6.swf:94b4de2a590c915696b4a783338a1f05
 stringlength-7.swf:140952977abb85b966f1e5c4447854ce
+string-properties-5.swf:39cc1143e531659d37072534a3d3455e
 string-properties-6.swf:6e04c332f503311867082ab55f22b16b
 string-properties-7.swf:bf61a4b0a4cc67c8df63203407ac243c
 string-properties-8.swf:b5d56ec26bad2fa2c7833f44e5148fd8