[Gnash-commit] gnash ChangeLog server/as_value.cpp testsuite/a...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  08/04/02 08:21:50

Modified files:
        .              : ChangeLog 
        server         : as_value.cpp 
        testsuite/actionscript.all: ops.as 
        testsuite/misc-swfc.all: swf4opcode.sc 

Log message:
        "true" and "false" have no special meaning when converting to bool !

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.6155&r2=1.6156
http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_value.cpp?cvsroot=gnash&r1=1.127&r2=1.128
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/ops.as?cvsroot=gnash&r1=1.37&r2=1.38
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-swfc.all/swf4opcode.sc?cvsroot=gnash&r1=1.10&r2=1.11

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.6155
retrieving revision 1.6156
diff -u -b -r1.6155 -r1.6156
--- ChangeLog   2 Apr 2008 08:10:30 -0000       1.6155
+++ ChangeLog   2 Apr 2008 08:21:48 -0000       1.6156
@@ -1,5 +1,12 @@
 2008-04-01 Sandro Santilli <address@hidden>
 
+       * server/as_value.cpp (to_bool_v5, to_bool_v6): "true" and "false"
+         have no special meaning !
+       * testsuite/actionscript.all/ops.as: pass !"true" is false in swf<7.
+       * testsuite/misc-swfc.all/swf4opcode.sc: pass !"true".
+
+2008-04-01 Sandro Santilli <address@hidden>
+
        * testsuite/misc-swfc.all/swf4opcode.sc: test ACTION_LOGICALNOT, gnash
          fails a "true" and a "_root" in swf4.
        * testsuite/actionscript.all/ops.as: test ACTION_LOGICALNOT, gnash

Index: server/as_value.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/as_value.cpp,v
retrieving revision 1.127
retrieving revision 1.128
diff -u -b -r1.127 -r1.128
--- server/as_value.cpp 1 Apr 2008 23:33:32 -0000       1.127
+++ server/as_value.cpp 2 Apr 2008 08:21:49 -0000       1.128
@@ -543,15 +543,10 @@
            {
                case  STRING:
                {
-                       if (getStr() == "false") return false;
-                       else if (getStr() == "true") return true;
-                       else
-                       {
                                double num = to_number();
                                bool ret = num && ! isnan(num);
                                return ret;
                        }
-               }
                case NUMBER:
                {
                        double d = getNum();
@@ -580,15 +575,10 @@
            {
                case  STRING:
                {
-                       if (getStr() == "false") return false;
-                       else if (getStr() == "true") return true;
-                       else
-                       {
                                double num = to_number();
                                bool ret = num && ! isnan(num);
                                return ret;
                        }
-               }
                case NUMBER:
                {
                        double d = getNum();

Index: testsuite/actionscript.all/ops.as
===================================================================
RCS file: /sources/gnash/gnash/testsuite/actionscript.all/ops.as,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -b -r1.37 -r1.38
--- testsuite/actionscript.all/ops.as   2 Apr 2008 08:07:08 -0000       1.37
+++ testsuite/actionscript.all/ops.as   2 Apr 2008 08:21:49 -0000       1.38
@@ -21,7 +21,7 @@
  */
 
 
-rcsid="$Id: ops.as,v 1.37 2008/04/02 08:07:08 strk Exp $";
+rcsid="$Id: ops.as,v 1.38 2008/04/02 08:21:49 strk Exp $";
 #include "check.as"
 
 //--------------------------------------------
@@ -774,7 +774,7 @@
 check(!"");
 #if OUTPUT_VERSION < 7
  check(!"a");
- xcheck(!"true"); 
+ check(!"true"); 
  check(!"false"); 
  check(!"0000.000"); 
 #else

Index: testsuite/misc-swfc.all/swf4opcode.sc
===================================================================
RCS file: /sources/gnash/gnash/testsuite/misc-swfc.all/swf4opcode.sc,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -b -r1.10 -r1.11
--- testsuite/misc-swfc.all/swf4opcode.sc       2 Apr 2008 08:10:31 -0000       
1.10
+++ testsuite/misc-swfc.all/swf4opcode.sc       2 Apr 2008 08:21:49 -0000       
1.11
@@ -150,7 +150,7 @@
         //
         check(!"");
         check(!"a");
-        xcheck(!"true");
+        check(!"true");
         check(!"false");
         check("1");
         check(!"0000.000");