Re: [Gnash-commit] gnash ChangeLog libamf/element.cpp libnet/cque....

[Rob Savoye]

strk wrote:
> On Mon, Apr 07, 2008 at 02:27:54PM -0600, Rob Savoye wrote:

> Maybe we can add another argument to contain the max size we want the
> merged buffer to have ?

  That's handled by the size of the buffer. The buffer's max size for
the copy is limited by the size of the destination Buffer's size, which
is initialized at constructor time with a size of totalsize.

> The important thing is to define ownership of those buffers, which
> is finding out which class is responsible to get rid of them.

  Those buffers are all owned by the CQue class, as a buffer is just a
dequeue of pointers to Buffers.

> Smart pointers may help for both shared ownership and ownership
> transfer.

  I dislike smart pointers for this kind of thing, and prefer to screw
with real pointers when manipulating real memory buffers like required
by a binary protocol. Even C++ is pretty useless when it comes to this
type of coding.

        - rob -