Re: [Gnash-commit] gnash/server/swf StartSoundTag.cpp StartSoundTag.h

[zou lunkai]

> Note that there's a DisplayListTag too, from which Place and Remove tags 
> derive.
> If you take a look at the doxygen diagram you find that there are other childs
> of ControlTag:
>
>        start_stream_sound_tag
>        SetBackgroundColorTag
>
sorry, I was a bit in a rush today.  I did give a search for all the
files contain ControlTag, but still forgot something.  And unluckly
both the compiler and "make check" didn't caught this regresion.
Anyhow, you have already fixed it. So I just need to say thanks:)

>
> Was there a problem in making ControlTag::execute a pure-virtual ?
>
hmm, just found pure-virtual function can still have a function body
and be called, so should be no problem.  And I agree it does need to
be pure-virtual to prevent such careless mistakes(derived class forget
to override base class virtual functions).

--zou



On 4/30/08, strk <address@hidden> wrote:
> On Wed, Apr 30, 2008 at 10:09:45AM +0000, Zou Lunkai wrote:
> > CVSROOT:      /sources/gnash
> > Module name:  gnash
> > Changes by:   Zou Lunkai <zoulunkai>  08/04/30 10:09:45
> >
> > Modified files:
> >       server/swf     : StartSoundTag.cpp StartSoundTag.h
> >
> > Log message:
> >       * server/swf/StartSoundTag.{h,cpp}: execute(), take an extra dlist
> >         argument, keep consistent with its base class(thanks strk for 
> > reviewing).
>
> Note that there's a DisplayListTag too, from which Place and Remove tags 
> derive.
> If you take a look at the doxygen diagram you find that there are other childs
> of ControlTag:
>
>        start_stream_sound_tag
>        SetBackgroundColorTag
>
> Was there a problem in making ControlTag::execute a pure-virtual ?
>
> --strk;
>