gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash/libamf README


From: strk
Subject: Re: [Gnash-commit] gnash/libamf README
Date: Wed, 30 Apr 2008 16:05:17 +0200

On Wed, Apr 30, 2008 at 01:32:16PM +0000, Rob Savoye wrote:

> Note to developers. Please be very careful making any changes to this
> code without seriously understanding how the code works. 

A few question aimed at understanding the code follow.

> As a raw buffer is pretty useless for higher level processing, the
> Element class is used to represent an AMF object. After a buffer is
> read, it's data is extracted into a series of Elements. An Element
> still uses the Buffer class to hold the data, but often this is a much
> smaller buffer than the one used to read data.

Question1: Do instances of the Element own the Buffer they use for 
           holding the data they point to ? Are they responsible for
           releasing it ?

Question2: Element class has a _name member being a pointer.
           Is it supposed to point inside the Buffer ? Or who is
           responsible for its deletion ?
           NOTE that the assignment operator for Element doesn't
           copy the memory pointed-to by _name, while it's destructor
           delete it.

Question3: Element class contain a vector of Elements (_properties).
           Does it own those elements ? Who is responsible to
           release them ?

--strk;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]