[Gnash-commit] gnash ChangeLog server/swf/DoActionTag.h server...

[Benjamin Wolsey]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Benjamin Wolsey <bwy>   08/06/04 07:59:12

Modified files:
        .              : ChangeLog 
        server/swf     : DoActionTag.h tag_loaders.cpp 

Log message:
                * server/swf/tag_loaders.cpp: no need to log_unimpl with 
metadata
                  tag as it should be ignored by the player.
                * server/swf/DoActionTag.h: replace SIZET_FMT, drop 
gnashconfig.h
                  include.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.6796&r2=1.6797
http://cvs.savannah.gnu.org/viewcvs/gnash/server/swf/DoActionTag.h?cvsroot=gnash&r1=1.13&r2=1.14
http://cvs.savannah.gnu.org/viewcvs/gnash/server/swf/tag_loaders.cpp?cvsroot=gnash&r1=1.203&r2=1.204

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.6796
retrieving revision 1.6797
diff -u -b -r1.6796 -r1.6797
--- ChangeLog   3 Jun 2008 18:02:41 -0000       1.6796
+++ ChangeLog   4 Jun 2008 07:59:11 -0000       1.6797
@@ -1,3 +1,10 @@
+2008-06-04 Benjamin Wolsey <address@hidden>
+
+       * server/swf/tag_loaders.cpp: no need to log_unimpl with metadata
+         tag as it should be ignored by the player.
+       * server/swf/DoActionTag.h: replace SIZET_FMT, drop gnashconfig.h
+         include.
+
 2008-06-03 Benjamin Wolsey <address@hidden>
 
        * server/impl.cpp: indentation.

Index: server/swf/DoActionTag.h
===================================================================
RCS file: /sources/gnash/gnash/server/swf/DoActionTag.h,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -b -r1.13 -r1.14
--- server/swf/DoActionTag.h    30 Apr 2008 09:15:08 -0000      1.13
+++ server/swf/DoActionTag.h    4 Jun 2008 07:59:12 -0000       1.14
@@ -18,10 +18,6 @@
 #ifndef GNASH_SWF_DOACTIONTAG_H
 #define GNASH_SWF_DOACTIONTAG_H
 
-#ifdef HAVE_CONFIG_H
-#include "gnashconfig.h"
-#endif
-
 #include "ControlTag.h" // for inheritance
 #include "swf.h" // for tag_type definition
 #include "action_buffer.h" // for composition
@@ -74,7 +70,7 @@
 
                IF_VERBOSE_PARSE (
                log_parse(_("tag %d: do_action_loader"), tag);
-               log_parse(_("-- actions in frame " SIZET_FMT), 
m->get_loading_frame());
+               log_parse(_("-- actions in frame %d"), m->get_loading_frame());
                );
 
                m->addControlTag(da); // ownership transferred

Index: server/swf/tag_loaders.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/swf/tag_loaders.cpp,v
retrieving revision 1.203
retrieving revision 1.204
diff -u -b -r1.203 -r1.204
--- server/swf/tag_loaders.cpp  3 Jun 2008 08:35:05 -0000       1.203
+++ server/swf/tag_loaders.cpp  4 Jun 2008 07:59:12 -0000       1.204
@@ -1514,6 +1514,7 @@
     //         - only use if it is the *first* tag in the stream.
 }
 
+
 void
 metadata_loader(stream* in, tag_type tag, movie_definition* /*m*/)
 {
@@ -1524,13 +1525,13 @@
     in->read_string(metadata);
 
     IF_VERBOSE_PARSE (
-       log_parse(_("  metadata = [[\n%s\n]]"), metadata);
+       log_parse(_("  RDF metadata (information only): [[\n%s\n]]"), metadata);
     );
 
-    log_unimpl(_("METADATA tag unused: %s"), metadata);
-
-    // TODO: attach to movie_definition instead
-    //       (should we parse the XML maybe?)
+    // TODO: add to Movie Properties?
+    // The metadata tag exists exclusively for external
+    // description of the SWF file and should be ignored
+    // by the SWF player.
 
 }
 
@@ -1599,7 +1600,6 @@
                static_cast<void> (in->read_u32());
                std::string name;
                in->read_string(name);
-               name.c_str();
        }
 
        //TODO: Move this to execution time so that as_object can be used. bool 
success = a.read(in);