Re: [Gnash-commit] gnash ChangeLog server/movie_root.cpp server/as...

[strk]

On Thu, Jun 05, 2008 at 10:08:34AM +0000, Benjamin Wolsey wrote:
> CVSROOT:      /sources/gnash
> Module name:  gnash
> Changes by:   Benjamin Wolsey <bwy>   08/06/05 10:08:33
> 
> Modified files:
>       .              : ChangeLog 
>       server         : movie_root.cpp as_environment.cpp 
> 
> Log message:
>               * server/as_environment.cpp: fix warning, minor changes.
>               * server/movie_root.cpp: don't disable scripts when we hit
>                 the recursion limit. A recursion limit can be 0 or 1, so
>                 mouse and key notifiers need to catch the ActionLimits 
> exception.
>                 It may be better not to call them. This makes Gnash behaviour 
> more
>                 or less compatible, though in some cases we may be pushing 
> less on
>                 the stack than we should, which of course changes behaviour.
>       
>               Real-life cases sometimes show different behaviour from what's
>               expected when the limit is very low. This may be for other
>               reasons than the stack limit. Probably it's more important that 
>               Gnash have a sensible policy with recursion than compatibility 
> in
>               every regard (though this would be good too), as it's an
>               undocumented feature and tends to be used to extend the 
> recursion
>               limit when required, not for achieving fine-grained effects.

Speaking of which, should we (or do we already) set an upper-limit  for limits ?
I guess we should have at least a compile-time limit, plus a user-defined one...

--strk;