[Gnash-commit] gnash/libmedia sound_handler.h

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  08/06/17 14:12:22

Modified files:
        libmedia       : sound_handler.h 

Log message:
        add some notes/complains about sound_handler interface

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/libmedia/sound_handler.h?cvsroot=gnash&r1=1.22&r2=1.23

Patches:
Index: sound_handler.h
===================================================================
RCS file: /sources/gnash/gnash/libmedia/sound_handler.h,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -b -r1.22 -r1.23
--- sound_handler.h     17 Jun 2008 12:31:43 -0000      1.22
+++ sound_handler.h     17 Jun 2008 14:12:22 -0000      1.23
@@ -57,6 +57,16 @@
 /// You may define a subclass of this, and pass an instance to
 /// set_sound_handler().
 ///
+/// NOTE
+/// The role of this class is currently somewhat confusing.
+/// The main service it should offer is mixing of gnash core sounds.
+/// Additionally it currently does on-demand decoding too for
+/// some kind of sounds (but not all).
+/// Also, it is unspecified what drives consumption of sound.
+/// For SDL handler the clock is driven by SDL lib itself.
+/// For GST, I have no idea..
+/// TODO: clean this up.
+///
 class DSOEXPORT sound_handler
 {
 public: