Re: [Gnash-commit] /srv/bzr/gnash/trunk r9740: Fix for bug #24265 (crash loading malformed jpeg).

[strk]

On Mon, Sep 15, 2008 at 11:05:23AM +0200, Benjamin Wolsey wrote:

> +        try
> +        {
> +            switch (inChannel->imageType())
> +            {
> +                case GNASH_IMAGE_RGB:
> +                    im.reset(new image::ImageRGB(width, height));
> +                    break;
> +                case GNASH_IMAGE_RGBA:
> +                    im.reset(new image::ImageRGBA(width, height));
> +                    break;
> +                default:
> +                    log_error("Invalid image returned");
> +                    return im;
> +            }
> +        }
> +        catch (std::bad_alloc& e)
> +        {
> +            return im;        
>          }

Was the catch really needed here ?
If it was, shouldn't we catch std::exception directly ?

--strk;