[Gnash-commit] /srv/bzr/gnash/trunk r9834: Small improvement to logging, correct propflags.

[Benjamin Wolsey]

------------------------------------------------------------
revno: 9834
committer: Benjamin Wolsey <address@hidden>
branch nick: trunk
timestamp: Thu 2008-09-25 09:06:41 +0200
message:
  Small improvement to logging, correct propflags.
  
  More help interpreting the swfdec testsuite run.
modified:
  libcore/StreamProvider.cpp
  libcore/asobj/flash/geom/Rectangle_as.cpp
  libcore/asobj/flash/geom/Transform_as.cpp
  testsuite/swfdec/Makefile.am
  testsuite/swfdec/PASSING
    ------------------------------------------------------------
    revno: 9831.1.1
    committer: Benjamin Wolsey <address@hidden>
    branch nick: work
    timestamp: Thu 2008-09-25 08:33:26 +0200
    message:
      Add a total count of all non-matching lines in a swfdec testsuite run (as
      a guide to catch changes that don't get XPASSes or FAILs).
    modified:
      testsuite/swfdec/Makefile.am
    ------------------------------------------------------------
    revno: 9831.1.2
    committer: Benjamin Wolsey <address@hidden>
    branch nick: work
    timestamp: Thu 2008-09-25 09:01:28 +0200
    message:
      Correct Transform properties.
    modified:
      libcore/asobj/flash/geom/Transform_as.cpp
    ------------------------------------------------------------
    revno: 9831.1.3
    committer: Benjamin Wolsey <address@hidden>
    branch nick: work
    timestamp: Thu 2008-09-25 09:03:10 +0200
    message:
      Improve logging.
    modified:
      libcore/StreamProvider.cpp
    ------------------------------------------------------------
    revno: 9831.1.4
    committer: Benjamin Wolsey <address@hidden>
    branch nick: work
    timestamp: Thu 2008-09-25 09:03:25 +0200
    message:
      Split long lines.
    modified:
      libcore/asobj/flash/geom/Rectangle_as.cpp
    ------------------------------------------------------------
    revno: 9831.1.5
    committer: Benjamin Wolsey <address@hidden>
    branch nick: work
    timestamp: Thu 2008-09-25 09:06:08 +0200
    message:
      Transform properties 8 now passes.
    modified:
      testsuite/swfdec/PASSING

=== modified file 'libcore/StreamProvider.cpp'
--- a/libcore/StreamProvider.cpp        2008-09-17 07:16:12 +0000
+++ b/libcore/StreamProvider.cpp        2008-09-25 07:03:10 +0000
@@ -114,7 +114,11 @@
 
     if (url.protocol() == "file")
     {
-        log_error("Request Headers discarded while getting stream from file: 
uri");
+        if (!headers.empty())
+        {
+            log_error("Request Headers discarded while getting stream "
+                    "from file: uri");
+        }
         return getStream(url, postdata);
     }
 
@@ -136,7 +140,11 @@
 
        if (url.protocol() == "file")
        {
-               log_error(_("POST data discarded while getting a stream from 
file: uri"));
+        if (!postdata.empty())
+        {    
+                   log_error(_("POST data discarded while getting a stream "
+                        "from file: uri"));
+        }
                std::string path = url.path();
                if ( path == "-" )
                {

=== modified file 'libcore/asobj/flash/geom/Rectangle_as.cpp'
--- a/libcore/asobj/flash/geom/Rectangle_as.cpp 2008-09-22 14:17:23 +0000
+++ b/libcore/asobj/flash/geom/Rectangle_as.cpp 2008-09-25 07:03:25 +0000
@@ -84,12 +84,18 @@
     o.init_member("toString", new builtin_function(Rectangle_toString), 0);
     o.init_member("union", new builtin_function(Rectangle_union), 0);
     o.init_property("bottom", Rectangle_bottom_getset, 
Rectangle_bottom_getset, 0);
-    o.init_property("bottomRight", Rectangle_bottomRight_getset, 
Rectangle_bottomRight_getset, 0);
-    o.init_property("left", Rectangle_left_getset, Rectangle_left_getset, 0);
-    o.init_property("right", Rectangle_right_getset, Rectangle_right_getset, 
0);
-    o.init_property("size", Rectangle_size_getset, Rectangle_size_getset, 0);
-    o.init_property("top", Rectangle_top_getset, Rectangle_top_getset, 0);
-    o.init_property("topLeft", Rectangle_topLeft_getset, 
Rectangle_topLeft_getset, 0);
+    o.init_property("bottomRight", Rectangle_bottomRight_getset,
+            Rectangle_bottomRight_getset, 0);
+    o.init_property("left", Rectangle_left_getset,
+            Rectangle_left_getset, 0);
+    o.init_property("right", Rectangle_right_getset,
+            Rectangle_right_getset, 0);
+    o.init_property("size", Rectangle_size_getset,
+            Rectangle_size_getset, 0);
+    o.init_property("top", Rectangle_top_getset,
+            Rectangle_top_getset, 0);
+    o.init_property("topLeft", Rectangle_topLeft_getset,
+            Rectangle_topLeft_getset, 0);
 }
 
 

=== modified file 'libcore/asobj/flash/geom/Transform_as.cpp'
--- a/libcore/asobj/flash/geom/Transform_as.cpp 2008-09-22 14:17:23 +0000
+++ b/libcore/asobj/flash/geom/Transform_as.cpp 2008-09-25 07:01:28 +0000
@@ -49,21 +49,23 @@
 static void
 attachTransformInterface(as_object& o)
 {
+    const int protectedFlags = as_prop_flags::isProtected;
+
     o.init_property("colorTransform",
             Transform_colorTransform_getset,
-            Transform_colorTransform_getset);
+            Transform_colorTransform_getset, protectedFlags);
     o.init_property("concatenatedColorTransform",
             Transform_concatenatedColorTransform_getset,
-            Transform_concatenatedColorTransform_getset);
+            Transform_concatenatedColorTransform_getset, protectedFlags);
     o.init_property("concatenatedMatrix",
             Transform_concatenatedMatrix_getset,
-            Transform_concatenatedMatrix_getset);
+            Transform_concatenatedMatrix_getset, protectedFlags);
     o.init_property("matrix",
             Transform_matrix_getset,
-            Transform_matrix_getset);
+            Transform_matrix_getset, protectedFlags);
     o.init_property("pixelBounds",
             Transform_pixelBounds_getset,
-            Transform_pixelBounds_getset);
+            Transform_pixelBounds_getset, protectedFlags);
 }
 
 static void

=== modified file 'testsuite/swfdec/Makefile.am'
--- a/testsuite/swfdec/Makefile.am      2008-06-09 19:53:46 +0000
+++ b/testsuite/swfdec/Makefile.am      2008-09-25 06:33:26 +0000
@@ -173,7 +173,8 @@
           for i in "$(TEST_CASES)"; do \
            GNASH_GC_TRIGGER_THRESHOLD=0 GNASHRC=../gnashrc $(SHELL) $$i; \
          done; \
-       fi
+       fi; \
+       echo "Number of discrepant lines (for information only): `grep -e 
"^-\|^+" *.log | wc -l`"
 
 site-update: site.exp
        @rm -fr site.exp.bak

=== modified file 'testsuite/swfdec/PASSING'
--- a/testsuite/swfdec/PASSING  2008-09-23 20:26:42 +0000
+++ b/testsuite/swfdec/PASSING  2008-09-25 07:06:08 +0000
@@ -1095,6 +1095,7 @@
 Transform-matrix-7.swf:c4110453b8151dd87efff882e5b312ca
 transform-properties-5.swf:9332e41f53db6ec456387efffd9e12a7
 transform-properties-5.swf:b0386824584340e1d0a80f986ce779b9
+transform-properties-8.swf:47331702f04553a41f57842ebfd081f8
 transform.swf:5c8533f9168ca3e92d000ce1693ed5ef
 try-6.swf:f9672870259f993617e5e41cf2e0bb95
 try-7.swf:8424e6654fbec5473daa8563d5b4b5a8