[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] /srv/bzr/gnash/trunk r9924: libmedia:
From: |
strk |
Subject: |
Re: [Gnash-commit] /srv/bzr/gnash/trunk r9924: libmedia: |
Date: |
Sun, 5 Oct 2008 17:04:04 +0200 |
On Sun, Oct 05, 2008 at 02:11:29AM +0200, Bastiaan Jacques wrote:
> MediaParser.cpp: Move thread::join() out of the destructor. As the
> destructor is run *after* the child constructor (i.e,
> ~MediaParser{Gst,Ffmpeg}), the parser thread, will be running after
> the child destructor has finished. If the parser thread then attempts
> to access the child data (which is expected), Pandora's box opens. Now,
> every user of MediaParser must call join() before it destroys the
> MediaParser object.
Wouldn't it be better to call ::join from the subclass destructors then ?
The less threading we expose externally, the better.
--strk;