[Gnash-commit] /srv/bzr/gnash/trunk r10417: visit values in enumeration order. fixes the SharedObject write test. BINARY COMPATIBLE NOW!

[Sandro Santilli]

------------------------------------------------------------
revno: 10417
committer: Sandro Santilli <address@hidden>
branch nick: trunk
timestamp: Sat 2008-12-13 23:59:25 +0100
message:
  visit values in enumeration order. fixes the SharedObject write test. BINARY 
COMPATIBLE NOW!
modified:
  libcore/PropertyList.h
  testsuite/misc-ming.all/SharedObjectTestRunner.sh

=== modified file 'libcore/PropertyList.h'
--- a/libcore/PropertyList.h    2008-12-13 22:29:05 +0000
+++ b/libcore/PropertyList.h    2008-12-13 22:59:25 +0000
@@ -109,7 +109,7 @@
        /// @param visitor
        ///     The visitor function. Must take a string_table::key 
        ///     reference as first argument and a const as_value reference
-       ///     as second argument.
+       ///     as second argument. Scan by enumeration order.
        ///
        /// @param this_ptr
        ///     The object reference used to extract values from properties.
@@ -117,8 +117,9 @@
        template <class V>
        void visitValues(V& visitor, const as_object& this_ptr) const
        {
-               for (container::const_iterator it = _props.begin(),
-                       itEnd = _props.end(); it != itEnd; ++it)
+        typedef container::nth_index<1>::type ContainerByOrder;
+        for (ContainerByOrder::const_reverse_iterator 
it=_props.get<1>().rbegin(),
+            ie=_props.get<1>().rend(); it != ie; ++it)
                {
                        as_value val = it->getValue(this_ptr);
                        visitor.accept(it->mName, val);

=== modified file 'testsuite/misc-ming.all/SharedObjectTestRunner.sh'
--- a/testsuite/misc-ming.all/SharedObjectTestRunner.sh 2008-12-10 10:06:17 
+0000
+++ b/testsuite/misc-ming.all/SharedObjectTestRunner.sh 2008-12-13 22:59:25 
+0000
@@ -89,10 +89,10 @@
                continue
        fi
        if ! cmp ${INPUTSOLDIR}/${solname} ${SOLDIR}/${solname}; then
-               echo "XFAILED: ! cmp ${SOLDIR}/${solname} 
${INPUTSOLDIR}/${solname}"
+               echo "FAILED: ! cmp ${SOLDIR}/${solname} 
${INPUTSOLDIR}/${solname}"
                continue
        fi
-       echo "XPASSED: SharedObject ${solname} matches input"
+       echo "PASSED: SharedObject ${solname} matches input"
 done
 
 #####################################################