[Gnash-commit] /srv/bzr/gnash/trunk r10453: Make the remoting test sensitive to OUTPUT_VERSION, build in version 7 by default (an array length changes semantic based on that)

[Sandro Santilli]

------------------------------------------------------------
revno: 10453
committer: Sandro Santilli <address@hidden>
branch nick: trunk
timestamp: Wed 2008-12-17 21:05:25 +0100
message:
  Make the remoting test sensitive to OUTPUT_VERSION, build in version 7 by 
default (an array length changes semantic based on that)
modified:
  testsuite/misc-ming.all/Makefile.am
  testsuite/misc-ming.all/remoting.as

=== modified file 'testsuite/misc-ming.all/Makefile.am'
--- a/testsuite/misc-ming.all/Makefile.am       2008-12-16 19:44:02 +0000
+++ b/testsuite/misc-ming.all/Makefile.am       2008-12-17 20:05:25 +0000
@@ -1727,7 +1727,7 @@
        $(NULL)
 
 remoting.swf: $(srcdir)/remoting.as Dejagnu.swf Makefile 
../actionscript.all/check.as ../actionscript.all/utils.as
-       $(MAKESWF) -n network -r12 -o $@ -v6 
-DHTTP_TESTSUITE='\"$(HTTP_TESTSUITE)\"' -DUSE_DEJAGNU_MODULE 
-DOUTPUT_VERSION=6 Dejagnu.swf $(srcdir)/remoting.as 
$(srcdir)/../actionscript.all/dejagnu_so_fini.as
+       $(MAKESWF) -n network -r12 -o $@ -v7 
-DHTTP_TESTSUITE='\"$(HTTP_TESTSUITE)\"' -DUSE_DEJAGNU_MODULE 
-DOUTPUT_VERSION=7 Dejagnu.swf $(srcdir)/remoting.as 
$(srcdir)/../actionscript.all/dejagnu_so_fini.as
 
 remotingTestRunner: $(srcdir)/../generic-testrunner.sh remoting.swf
        sh $< $(top_builddir) remoting.swf > $@

=== modified file 'testsuite/misc-ming.all/remoting.as'
--- a/testsuite/misc-ming.all/remoting.as       2008-12-16 19:44:02 +0000
+++ b/testsuite/misc-ming.all/remoting.as       2008-12-17 20:05:25 +0000
@@ -131,7 +131,7 @@
 
     o={onStatus:handleOnStatus};
     ary6=['0','0','0'];
-    ary6.custom='custom'; AsSetPropFlags(ary6, 'custom', 1); // hide from 
enumeration
+    ary6.custom='custom'; ASSetPropFlags(ary6, 'custom', 1); // hide from 
enumeration
     nc.call("ary_000_assetpropflags", o, ary6); // 36
     o.onResult = function(res) {
         //note(printInfo(res));
@@ -156,9 +156,13 @@
         check_equals(res.request_id, '/7');
         check_equals(res.message, 'ary_float');
         check_equals(res.arg1_type, 'ECMA_ARRAY');
+#if OUTPUT_VERSION > 6
+        check_equals(res.hex, 
'0a:00:00:00:01:08:00:00:00:00:00:03:32:2e:35:00:3f:f0:00:00:00:00:00:00:00:00:09');
+#else
         // The bug here is that gnash encodes 0 as the length of the array 
while
-        // the expected behaviour is to encode 3.
+        // the expected behaviour is to encode 3 (for SWF6 or lower!)
         xcheck_equals(res.hex, 
'0a:00:00:00:01:08:00:00:00:03:00:03:32:2e:35:00:3f:f0:00:00:00:00:00:00:00:00:09');
+#endif
     };
 
     o={onStatus:handleOnStatus};