Re: [Gnash-commit] /srv/bzr/gnash/trunk r10707: Drop obsoleted TODO item (fill styles are not recreated for subshapes anymore)

[Sandro Santilli]

On Mon, Mar 16, 2009 at 01:10:22PM -0700, Bastiaan Jacques wrote:
> Perhaps that comment was intended to refer to shape character def
> instead? The "if they never change" part of the comment only makes sense 
> to me in that context, at any rate.

- Converted fill styles (for AGG) are recreated for each sub-shape, even if
  they never change for a shape. This should be changed.

"recreated for each sub-shape" seem pretty clear to me.

I think "even if they never change" refers to the fact that
the core lib never calls for rendering a single sub-shape, but
always full shapes, so they don't change during the single
call to AGG...

In any case, what you have in mind is "caching" which is
listed on top as something not implemented yet.

Currently, an agg_style_handler class is used to contain
those "converted styles", and passed around while rendering
subshapes. The comment probably predates agg_style_handler.

--strk;

 Free GIS & Flash consultant/developer      ()  ASCII Ribbon Campaign
 http://foo.keybit.net/~strk/services.html  /\  Keep it simple!