[Gnash-commit] /srv/bzr/gnash/trunk r10710: Add TODO item with documentation about how we should decide when to smoot bitmap fills and when not to. We're currently doing it WRONG (more quality, more CPU load than required)

[Sandro Santilli]

------------------------------------------------------------
revno: 10710
committer: Sandro Santilli <address@hidden>
branch nick: trunk
timestamp: Tue 2009-03-17 11:19:12 +0100
message:
  Add TODO item with documentation about how we should decide when to smoot 
bitmap fills and when not to. We're currently doing it WRONG (more quality, 
more CPU load than required)
modified:
  backend/render_handler_agg.cpp

=== modified file 'backend/render_handler_agg.cpp'
--- a/backend/render_handler_agg.cpp    2009-03-16 19:32:06 +0000
+++ b/backend/render_handler_agg.cpp    2009-03-17 10:19:12 +0000
@@ -1306,7 +1306,25 @@
             (fill_styles[fno].get_bitmap_info()), m, cx, 
             (fill_type==SWF::FILL_TILED_BITMAP) ||
             (fill_type==SWF::FILL_TILED_BITMAP_HARD),
-            smooth && _quality >= QUALITY_HIGH);
+
+            smooth &&
+            // TODO:
+            //
+            // Non-HARD bitmap fills are smoothed or
+            // not depending on _quality and SWF version:
+            // - For SWF8 and up (where _HARD versions are available)
+            //   they are smoothed starting at quality MEDIUM.
+            // - For previous SWF versions they are only smoothed
+            //   with quality BEST
+            //
+            // NOTE: the SWF version to take into account here is
+            //       the one of the file containing the definition
+            //       of the fills, not the top-level file loaded.
+            //
+            // It needs to be checked behaviour for bitmap
+            // fills produced with ActionScript
+            //
+            _quality >= QUALITY_HIGH);
           break;
         }