[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Re: [Gnash-commit] /srv/bzr/gnash/trunk r10720: setQuality() has to
From: |
strk |
Subject: |
Re: Re: [Gnash-commit] /srv/bzr/gnash/trunk r10720: setQuality() has to be used in movie_root initialization to inform the renderer |
Date: |
Thu, 19 Mar 2009 10:12:33 +0100 |
On Thu, Mar 19, 2009 at 09:44:56AM +0100, Benjamin Wolsey wrote:
>
> >
> > The problem is:
> > - You have a huge (full-screen) bitmap
> > - Trying to reduce client load you set _quality
> > in frame0
> > - Gnash will keep redrawing the bitmap, even
> > if not required (as _quality doesn't change)
> >
>
> I see the potential problem, but the two questions are: (a) what does the pp
> do? There's no reason why Gnash shouldn't be more efficient than the pp, but
> still if the pp forces a full redraw on each change of _quality it would be a
> reason for SWF designers not to do it; and (b) related: are there any actual
> cases of this? Bearing in mind it's possible for the SWF to check for quality
> before changing it.
I committed a version that only wraps the setInvalidated call
in the conditional (don't force redraw if quality doesn't change).
See if it works for you.
--strk;