Re: [Gnash-commit] /srv/bzr/gnash/trunk r10819: add Tomeu Vizoso's patch to make Gnash be a gtk widget and python module.

[Rob Savoye]

Benjamin Wolsey wrote:
> I don't think this code is yet quite ready to be used, particularly not
> as the default. It looks like it does lots of good things, but breaks

  It shouldn't have broken gtk-gnash, it was working for me when I
checked it in. I can make it optional for the time being, but I like the
idea of a Gnash Gtk widget. It is probably only the one canvas file
causing trouble.

> The patch doesn't use Gnash's coding or naming style

  Neither does a large amount of other code in Gnash... even a core
developer ignores the Gnash coding style for their own. My hope is now
that the code builds, that as Tomeu keeps working in the code, he can
make the other changes you've mentioned. AS he's not on the commit list,
you'll want to send it to him or grab him on irc.

> gnash-canvas.{h,cpp} introduces yet another file naming style. Can we
> stick to either gnash_canvas.cpp or GnashCanvas.cpp? The latter reflects
> the class name, and has been used for recent code.

 Renaming it would be a good idea.

        - rob -