gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] /srv/bzr/gnash/trunk r11338: Revert Camera class chan


From: Benjamin Wolsey
Subject: Re: [Gnash-commit] /srv/bzr/gnash/trunk r11338: Revert Camera class changes until they work with ffmpeg too.
Date: Thu, 30 Jul 2009 16:05:21 +0200

>    It's not likely there will be time to add ffmpeg support to the 
> Camera and Microphone classes with the time left in our summer project.

There's no need to do that, and it's not what I was suggesting either.

>  
> While Gnash does need to still build with ffmpeg and no GST, and there 
> is further modularization that needs to be done, I'm just glad to see 
> input working at all. Rather than reverting this, I think it just needs 
> to ifdef the GST bits out so it still compiles.

It is hardly a great deal of work to add a couple of functions to the
MediaHandler and make sure the class still works when there is no input.
But even the ifdefs are all right as a short-term measure - it should
just be done before it's committed to trunk. The reversion was a quick
way of getting it to work again, and it is very easy to get the code
back and fix the build before committing.

--
Use Gnash, the GNU Flash Player!
http://www.gnu.org/software/gnash/

Benjamin Wolsey, Software Developer - http://benjaminwolsey.de

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil


reply via email to

[Prev in Thread] Current Thread [Next in Thread]